Rollup of 9 pull requests by Zalathar · Pull Request #165446 · rust-lang/rust

Zalathar · 2026-11-04T04:10:15Z

Successful merges:

std: Clean up and improve errors for is_*_feature_detected macros #165011 (std: Clean up and improve errors for is_*_feature_detected macros)
Remove the label starting with 0 in the test binary_asm_labels_allowed.rs #164482 (Remove the label starting with 0 in the test binary_asm_labels_allowed.rs)
Fix constant-pattern equality suggestion spans in macros #165268 (Fix constant-pattern equality suggestion spans in macros)
Fix explicit destructor-call suggestion spans in macros #165318 (Fix explicit destructor-call suggestion spans in macros)
[Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc) #164440 ([Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc))
Document allocator swap in BinaryHeap::append #165001 (Document allocator swap in BinaryHeap::append)
Impl read_le/read_be for f16 and f128 #165330 (Impl read_le/read_be for f16 and f128)
Remove unusued query key impl #165414 (Remove unusued query key impl)
docker: bump node to v24.22.2 in shared script #165440 (docker: bump node to v24.22.2 in shared script)

…d.rs 0-prefixed labels are not accepted anymore with GNU as, so this is necessary to make this test pass with rustc_codegen_gcc.

It can be a bit tricky to follow these macros, but we still want to provide good diagnostics. Add tests making sure these don't change.

Because of rewrapping, this prints as: error: This macro cannot be used on the current target. You can prevent it from being used in other architectures by guarding it behind a cfg(any(target_arch = "aarch64", target_arch = "arm64ec")). Bridge newlines so it instead prints as this: error: This macro cannot be used on the current target. You can prevent it from being used in other architectures by guarding it behind a `cfg(any(target_arch = "aarch64", target_arch = "arm64ec"))`.

We have a handful of `#[unstable]` gates that aren't even being used, because all that matters is the re-export in `std`. For example, the RISC-V macro appears unstable, but has actually been stable since 1.78 <https://doc.rust-lang.org/1.78.0/std/arch/macro.is_riscv_feature_detected.html>.

Rather than transmuting discriminants, use the macros to generate a list of all features that we can iterate instead. This also allows us to remove the sentinel `_last` entry.

…Arc, Rc) * alloc: Add test coverage for try_clone_from_ref_in * alloc: test cloning zero-sized values from references * alloc: format zero-sized clone test * alloctests: remove obsolete const_btree_len feature * alloctests: fix feature attribute formatting

…nGnome std: Clean up and improve errors for `is_*_feature_detected` macros This includes a handful of small changes around the internals of our feature detection macros: * Add UI tests, since this macro is pretty UI-forward but not yet covered anywhere * Remove misleading feature gates that aren't even being checked, e.g. what showed up in rust-lang#111192 (comment). * Clean up some errors and improve the comments around all of this This is done in a handful of separate commits, the messages have some more details.

…=tgross35 Remove the label starting with 0 in the test binary_asm_labels_allowed.rs 0-prefixed labels are not accepted anymore with recent GNU as, so this is necessary to make this test pass with rustc_codegen_gcc.

@estebank

Fix constant-pattern equality suggestion spans in macros Addresses rust-lang#164044 The ancestor lookup brings the initializer into the pattern’s context instead of always choosing the outermost call site, because the pattern itself may belong to an inner macro expansion. r? @estebank

@estebank

…ructor-call-suggestion, r=estebank Fix explicit destructor-call suggestion spans in macros Macro expansion can make suggestions for explicit destructor calls point to the wrong source location. This change maps the receiver’s span into the call’s syntax context and skips the suggestion when no suitable span can be found. Addresses the explicit destructor-call suggestion case in rust-lang#164044 r? @estebank

…in, r=nia-e [Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc) Description: LLM Disclosure: I used an AI assistant for local guidance while exploring the test structure and troubleshooting compiler errors (such as handling System allocator equality checks). I wrote this PR description, ran all tests, and verified the changes myself. **Summary** I added a UI test to verify `try_clone_from_ref_in ` across **Box, Arc, and Rc** using the System allocator as part of the Allocators 1.0 test coverage work. What’s included: - Added tests/ui/allocator/try-clone-from-ref-in.rs - Tested fallible cloning from references for **&str** and **&[i32]** slices with Box, **Arc,** and **Rc** - Verified feature gate handling (#![feature(clone_from_ref)]) - Ran `./x.py test tests/ui/allocator/try-clone-from-ref-in.rs` locally and the test passed.

…ocator-docs, r=nia-e Document allocator swap in BinaryHeap::append Added comments to be more specific about swap which occurs when `self` has fewer elements than `other`. Swap also swaps allocators leading to drop of `self` dropping the allocator that originally belonged to `other` and vice versa. The docs had no mention regarding this. Felt anyone using custom allocators should have this clarified. Issue origin: [rust-lang#32526](rust-lang#32526) Implemented in: [rust-lang#32987](rust-lang#32987)

Impl read_le/read_be for f16 and f128 Implements read_le/read_be (tracked by rust-lang#156984) for f16 and f128 (tracked by rust-lang#116909)

@adwinwhite

…querykey-impl, r=adwinwhite Remove unusued query key impl We no longer use these keys in any queries, so we can yeet them. r? @adwinwhite

@marcoieni

…, r=jieyouxu docker: bump node to v24.22.2 in shared script Context : https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Is.20our.20infra.20affected.20by.20revoked.20certs.3F/with/633490157 Another fix related to [emudhra CA certificates](https://emudhra.we-have-a-problem.com). Follow-up of rust-lang#164676. Here we bump the node version set in the shared Docker scripts to a release that ships a security fix. - [Security fix shipped in 24.22.1](https://nodejs.org/en/blog/release/v24.22.1) - [24.22.2 ships a few non-related backports](https://nodejs.org/en/blog/release/v24.22.2) I also change the control variable to bust the Docker cache for all images, so newer builds catch this update. r? @marcoieni

Rollup of 9 pull requests Successful merges: - #165011 (std: Clean up and improve errors for `is_*_feature_detected` macros) - #164482 (Remove the label starting with 0 in the test binary_asm_labels_allowed.rs) - #165268 (Fix constant-pattern equality suggestion spans in macros) - #165318 (Fix explicit destructor-call suggestion spans in macros) - #164440 ([Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc)) - #165001 (Document allocator swap in BinaryHeap::append) - #165330 (Impl read_le/read_be for f16 and f128) - #165414 (Remove unusued query key impl) - #165440 (docker: bump node to v24.22.2 in shared script)

rust-log-analyzer · 2026-11-04T06:10:35Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

rust-bors · 2026-11-04T06:11:44Z

💔 Test for 4d0ceb5 failed: CI. Failed job:

auto - dist-powerpc64le-linux-musl (web logs, enhanced plaintext logs)

Zalathar · 2026-11-04T06:22:39Z

Looks like a flaky download.

@bors try jobs=dist-powerpc64le-linux-musl
@bors retry

Rollup of 9 pull requests try-job: dist-powerpc64le-linux-musl

rust-bors · 2026-11-04T08:46:25Z

☀️ Try build successful (CI)
Build commit: 2962d92 (2962d923bc067803766996a0b2495b57ffe3b5b3)
Base parent: cabb1ea (cabb1ea4ced589dfee40c08aeffff3cac78af43b)

Rollup of 9 pull requests Successful merges: - #165011 (std: Clean up and improve errors for `is_*_feature_detected` macros) - #164482 (Remove the label starting with 0 in the test binary_asm_labels_allowed.rs) - #165268 (Fix constant-pattern equality suggestion spans in macros) - #165318 (Fix explicit destructor-call suggestion spans in macros) - #164440 ([Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc)) - #165001 (Document allocator swap in BinaryHeap::append) - #165330 (Impl read_le/read_be for f16 and f128) - #165414 (Remove unusued query key impl) - #165440 (docker: bump node to v24.22.2 in shared script)

jieyouxu · 2026-11-04T09:43:58Z

~~@Zalathar something strange seems to be going on with #165381... See #t-infra > Tree ops @ 💬~~

EDIT: nevermind, I just didn't find the commit.

rust-log-analyzer · 2026-11-04T10:13:43Z

The job test-x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   5: <bootstrap::core::builder::Builder>::ensure::<bootstrap::core::build_steps::toolstate::ToolStateCheck>
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1643:36
   6: <bootstrap::core::build_steps::toolstate::ToolStateCheck as bootstrap::core::builder::CommandLineStep>::make_run
             at /checkout/src/bootstrap/src/core/build_steps/toolstate.rs:230:21
   7: <bootstrap::core::builder::CommandLineStepDescription>::maybe_run
             at /checkout/src/bootstrap/src/core/builder/mod.rs:473:13
   8: bootstrap::core::builder::cli_paths::match_paths_to_steps_and_run
             at /checkout/src/bootstrap/src/core/builder/cli_paths.rs:138:19
   9: <bootstrap::core::builder::Builder>::run_step_descriptions
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1179:9

rust-bors · 2026-11-04T10:15:20Z

💔 Test for 5102f32 failed: CI. Failed job:

auto - test-x86_64-gnu-tools (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-11-04T10:22:11Z

@bors retry

Rollup of 9 pull requests Successful merges: - #165011 (std: Clean up and improve errors for `is_*_feature_detected` macros) - #164482 (Remove the label starting with 0 in the test binary_asm_labels_allowed.rs) - #165268 (Fix constant-pattern equality suggestion spans in macros) - #165318 (Fix explicit destructor-call suggestion spans in macros) - #164440 ([Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc)) - #165001 (Document allocator swap in BinaryHeap::append) - #165330 (Impl read_le/read_be for f16 and f128) - #165414 (Remove unusued query key impl) - #165440 (docker: bump node to v24.22.2 in shared script)

rust-bors · 2026-11-04T10:22:37Z

⌛ Testing commit 4f15142 with merge e119e44...

Workflow: https://github.com/rust-lang/rust/actions/runs/41813767941

JonathanBrouwer · 2026-11-04T10:22:41Z

@bors treeclosed=5 github outage

rust-bors · 2026-11-04T10:22:45Z

Tree closed for PRs with priority less than 5.

JonathanBrouwer · 2026-11-04T11:57:12Z

@bors treeopen

rust-bors · 2026-11-04T11:57:16Z

Tree is now open for merging.

antoyo and others added 25 commits October 17, 2026 13:20

Remove the label starting with 0 in the test binary_asm_labels_allowe…

f7d8e4a

…d.rs 0-prefixed labels are not accepted anymore with GNU as, so this is necessary to make this test pass with rustc_codegen_gcc.

Document allocator swap in BinaryHeap::append

4477617

Apply review suggestion for BinaryHeap::append docs

7b1da71

std: Add UI tests for feature detection macros

20ae3b6

It can be a bit tricky to follow these macros, but we still want to provide good diagnostics. Add tests making sure these don't change.

std: Add more documentation to the std_detect macros

51ff312

std: Simplify std_detect feature iteraion using a list

5f7505c

Rather than transmuting discriminants, use the macros to generate a list of all features that we can iterate instead. This also allows us to remove the sentinel `_last` entry.

Fix constant-pattern suggestion spans in macros

63f2b39

Fix explicit destructor-call suggestion spans in macros

34c44aa

impl_from_endian_bytes for f16 and f128

f6db665

fmt

ce9a827

add f16, f128 feature

d239ae1

remove unusued query key impl

8d41583

docker: bump node to v24.22.2 in shared script

0a75b4c

Rollup merge of rust-lang#165330 - valaphee:read_f16_f128, r=LawnGnome

8ab7eb6

Impl read_le/read_be for f16 and f128 Implements read_le/read_be (tracked by rust-lang#156984) for f16 and f128 (tracked by rust-lang#116909)

Rollup merge of rust-lang#165414 - bit-aloo:2026-11-03-remove-unused-…

3b51c82

…querykey-impl, r=adwinwhite Remove unusued query key impl We no longer use these keys in any queries, so we can yeet them. r? @adwinwhite

rust-bors Bot added the rollup A PR which is a rollup label Nov 4, 2026

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Nov 4, 2026

Auto merge of #165446 - Zalathar:rollup-glrIrby, r=<try>

2962d92

Rollup of 9 pull requests try-job: dist-powerpc64le-linux-musl

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2026

rust-bors Bot mentioned this pull request Nov 4, 2026

Apply the Cortex-A53 843419 CC mitigation to aarch64 targets #164752

Open

This was referenced Nov 4, 2026

Update books #165364

Open

Use correct source parameter spans in async closure inference diagnostics #162570

Open

Conversation

Zalathar commented Nov 4, 2026

Uh oh!

rust-log-analyzer commented Nov 4, 2026

Uh oh!

rust-bors Bot commented Nov 4, 2026

Uh oh!

Zalathar commented Nov 4, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Nov 4, 2026

Uh oh!

This comment has been minimized.

jieyouxu commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-log-analyzer commented Nov 4, 2026

Uh oh!

rust-bors Bot commented Nov 4, 2026

Uh oh!

JonathanBrouwer commented Nov 4, 2026

Uh oh!

rust-bors Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Nov 4, 2026

Uh oh!

rust-bors Bot commented Nov 4, 2026

Uh oh!

JonathanBrouwer commented Nov 4, 2026

Uh oh!

rust-bors Bot commented Nov 4, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

jieyouxu commented Nov 4, 2026 •

edited

Loading

rust-bors Bot commented Nov 4, 2026 •

edited

Loading