Rollup of 17 pull requests by JonathanBrouwer · Pull Request #165464 · rust-lang/rust

JonathanBrouwer · 2026-11-04T16:27:18Z

Successful merges:

Apply the Cortex-A53 843419 CC mitigation to aarch64 targets #164752 (Apply the Cortex-A53 843419 CC mitigation to aarch64 targets )
std: Clean up and improve errors for is_*_feature_detected macros #165011 (std: Clean up and improve errors for is_*_feature_detected macros)
Add Forget trait feature gate #165376 (Add Forget trait feature gate)
Remove the label starting with 0 in the test binary_asm_labels_allowed.rs #164482 (Remove the label starting with 0 in the test binary_asm_labels_allowed.rs)
Move a bunch of methods out of AttributeExt #165201 (Move a bunch of methods out of AttributeExt)
Fix constant-pattern equality suggestion spans in macros #165268 (Fix constant-pattern equality suggestion spans in macros)
Fix explicit destructor-call suggestion spans in macros #165318 (Fix explicit destructor-call suggestion spans in macros)
[Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc) #164440 ([Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc))
Document allocator swap in BinaryHeap::append #165001 (Document allocator swap in BinaryHeap::append)
Revert FCW on lint attributes on macro calls #165257 (Revert FCW on lint attributes on macro calls)
Impl read_le/read_be for f16 and f128 #165330 (Impl read_le/read_be for f16 and f128)
Update books #165364 (Update books)
Remove unusued query key impl #165414 (Remove unusued query key impl)
Update amdgpu datalayout for LLVM 24 #165424 (Update amdgpu datalayout for LLVM 24)
docker: bump node to v24.22.2 in shared script #165440 (docker: bump node to v24.22.2 in shared script)
Add Discriminant::ord #165443 (Add Discriminant::ord)
Add an unstable option to increase the chain depth of the next solver overflow FCW #165445 (Add an unstable option to increase the chain depth of the next solver overflow FCW)

…d.rs 0-prefixed labels are not accepted anymore with GNU as, so this is necessary to make this test pass with rustc_codegen_gcc.

It can be a bit tricky to follow these macros, but we still want to provide good diagnostics. Add tests making sure these don't change.

Because of rewrapping, this prints as: error: This macro cannot be used on the current target. You can prevent it from being used in other architectures by guarding it behind a cfg(any(target_arch = "aarch64", target_arch = "arm64ec")). Bridge newlines so it instead prints as this: error: This macro cannot be used on the current target. You can prevent it from being used in other architectures by guarding it behind a `cfg(any(target_arch = "aarch64", target_arch = "arm64ec"))`.

We have a handful of `#[unstable]` gates that aren't even being used, because all that matters is the re-export in `std`. For example, the RISC-V macro appears unstable, but has actually been stable since 1.78 <https://doc.rust-lang.org/1.78.0/std/arch/macro.is_riscv_feature_detected.html>.

Rather than transmuting discriminants, use the macros to generate a list of all features that we can iterate instead. This also allows us to remove the sentinel `_last` entry.

rust-bors · 2026-11-04T20:45:52Z

💔 Test for c0c7a3b failed: CI. Failed job:

auto - test-x86_64-gnu-tools (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-11-04T20:48:31Z

:c
@bors retry

maxdexh · 2026-11-04T21:29:49Z

Is it spreading to gnu?

…uwer Rollup of 17 pull requests Successful merges: - #164752 (Apply the Cortex-A53 843419 CC mitigation to aarch64 targets ) - #165011 (std: Clean up and improve errors for `is_*_feature_detected` macros) - #165376 (Add `Forget` trait feature gate) - #164482 (Remove the label starting with 0 in the test binary_asm_labels_allowed.rs) - #165201 (Move a bunch of methods out of `AttributeExt`) - #165268 (Fix constant-pattern equality suggestion spans in macros) - #165318 (Fix explicit destructor-call suggestion spans in macros) - #164440 ([Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc)) - #165001 (Document allocator swap in BinaryHeap::append) - #165257 (Revert FCW on lint attributes on macro calls) - #165330 (Impl read_le/read_be for f16 and f128) - #165364 (Update books) - #165414 (Remove unusued query key impl) - #165424 (Update amdgpu datalayout for LLVM 24) - #165440 (docker: bump node to v24.22.2 in shared script) - #165443 (Add `Discriminant::ord`) - #165445 (Add an unstable option to increase the chain depth of the next solver overflow FCW)

jhpratt · 2026-11-05T05:38:54Z

5ish minutes before a timeout. test-aarch64-apple-macos-26-2 is the only job remaining and is clearly making progress, so I'll retry if it times out.

rust-bors · 2026-11-05T05:44:01Z

💥 Test timed out after 21600s

jhpratt · 2026-11-05T05:45:23Z

@bors retry

@bors try jobs=test-aarch64-apple-macos-26-2

Rollup of 17 pull requests try-job: test-aarch64-apple-macos-26-2

rust-bors · 2026-11-05T07:37:14Z

☀️ Try build successful (CI)
Build commit: ef27372 (ef273723d34ed0b0a1a555860543b0c63028b32d)
Base parent: 2d20b42 (2d20b42b883dcfc014f3c2c56081eeb6091c2179)

rust-bors · 2026-11-05T10:56:37Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 2m 45s
Pushing 70424d8 to main...

github-actions · 2026-11-05T11:00:13Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2d20b42 (parent) -> 70424d8 (this PR)

Test differences

Show 196 test diffs

Stage 1

[ui] tests/ui/consts/const_in_pattern/equality-suggestion-issue-164044.rs: [missing] -> pass (J1)
[ui] tests/ui/drop/explicit-drop-macro-suggestions-suppressed.rs: [missing] -> pass (J1)
[ui] tests/ui/drop/explicit-drop-macro-suggestions.rs: [missing] -> pass (J1)
[ui] tests/ui/feature-gates/feature-gate-forget-trait.rs: [missing] -> pass (J1)
[ui] tests/ui/rust-2024/gen_in_macro_input.rs: [missing] -> pass (J1)
[ui] tests/ui/std/is_arch_feature_detected.rs#AARCH64: [missing] -> ignore (only executed when the architecture is aarch64) (J1)
[ui] tests/ui/std/is_arch_feature_detected.rs#X86: [missing] -> pass (J1)
[ui (polonius)] tests/ui/consts/const_in_pattern/equality-suggestion-issue-164044.rs: [missing] -> pass (J4)
[ui (polonius)] tests/ui/drop/explicit-drop-macro-suggestions-suppressed.rs: [missing] -> pass (J4)
[ui (polonius)] tests/ui/drop/explicit-drop-macro-suggestions.rs: [missing] -> pass (J4)
[ui (polonius)] tests/ui/feature-gates/feature-gate-forget-trait.rs: [missing] -> pass (J4)
[ui (polonius)] tests/ui/rust-2024/gen_in_macro_input.rs: [missing] -> pass (J4)
[ui (polonius)] tests/ui/std/is_arch_feature_detected.rs#AARCH64: [missing] -> ignore (only executed when the architecture is aarch64) (J4)
[ui (polonius)] tests/ui/std/is_arch_feature_detected.rs#X86: [missing] -> pass (J4)
[run-make] tests/run-make/a53-mitigation: [missing] -> ignore (only executed when the target is aarch64-unknown-linux-gnu) (J6)
boxed::try_clone_from_ref_in_zero_sized_type_skips_allocation: [missing] -> pass (J10)

Stage 2

[ui] tests/ui/std/is_arch_feature_detected.rs#X86: [missing] -> ignore (only executed when the architecture is x86_64) (J0)
[ui] tests/ui/consts/const_in_pattern/equality-suggestion-issue-164044.rs: [missing] -> pass (J2)
[ui] tests/ui/drop/explicit-drop-macro-suggestions-suppressed.rs: [missing] -> pass (J2)
[ui] tests/ui/drop/explicit-drop-macro-suggestions.rs: [missing] -> pass (J2)
[ui] tests/ui/feature-gates/feature-gate-forget-trait.rs: [missing] -> pass (J2)
[ui] tests/ui/rust-2024/gen_in_macro_input.rs: [missing] -> pass (J2)
[ui] tests/ui/std/is_arch_feature_detected.rs#AARCH64: [missing] -> pass (J3)
[run-make] tests/run-make/a53-mitigation: [missing] -> pass (J5)
[ui] tests/ui/std/is_arch_feature_detected.rs#AARCH64: [missing] -> ignore (only executed when the architecture is aarch64) (J7)
[ui] tests/ui/std/is_arch_feature_detected.rs#X86: [missing] -> pass (J8)
boxed::try_clone_from_ref_in_zero_sized_type_skips_allocation: [missing] -> pass (J9)
[run-make] tests/run-make/a53-mitigation: [missing] -> ignore (only executed when the target is aarch64-unknown-linux-gnu) (J11)

Additionally, 168 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 70424d844bbe2c6dbc8f38dda80affd754a7cfe4 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-x86_64-mingw-1: -> 3h 1m (+inf%)
test-x86_64-msvc-1: 1h 33m -> 2h 49m (+81.2%)
test-x86_64-msvc-2: 1h 31m -> 2h 37m (+72.3%)
test-x86_64-gnu-llvm-22: 37m 21s -> 1h 1m (+65.7%)
dist-s390x-linux: 59m 46s -> 1h 38m (+64.5%)
test-i686-gnu-2: 1h 9m -> 1h 46m (+54.1%)
dist-powerpc64-linux-gnu: 1h 7m -> 1h 42m (+52.9%)
dist-x86_64-musl: 1h 39m -> 2h 25m (+46.7%)
test-x86_64-gnu-distcheck: 1h 45m -> 2h 34m (+46.2%)
dist-x86_64-freebsd: 1h 3m -> 1h 31m (+45.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-11-05T11:45:44Z

Finished benchmarking commit (70424d8): comparison URL.

Overall result: ❌ regressions - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.7%]	12
Regressions ❌ (secondary)	0.4%	[0.2%, 1.1%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.2%, 0.7%]	12

Max RSS (memory usage)

Results (primary -1.6%, secondary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.7%	[1.7%, 1.7%]	1
Improvements ✅ (primary)	-1.6%	[-2.2%, -1.0%]	2
Improvements ✅ (secondary)	-2.6%	[-3.3%, -1.9%]	2
All ❌✅ (primary)	-1.6%	[-2.2%, -1.0%]	2

Cycles

Results (secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.4%	[2.6%, 9.7%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.0%	[-8.1%, -2.7%]	4
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 480.462s -> 482.473s (0.42%)
Artifact size: 406.22 MiB -> 406.29 MiB (0.02%)

rust-bors · 2026-11-05T12:04:28Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#164752	Apply the Cortex-A53 843419 CC mitigation to aarch64 target…	`3d00a13e90a83b7a54194a00bc2d5eb59db2457f` (link)
#165011	std: Clean up and improve errors for `is_*_feature_detected…	`cf6e715664f02337a88f6bf9944b15be7343a381` (link)
#165376	Add `Forget` trait feature gate	`2fa775b809086244dc27730daed4c5c9b7480cb9` (link)
#164482	Remove the label starting with 0 in the test binary_asm_lab…	`2865137e5610112e48621a62b10d223d2a042c94` (link)
#165201	Move a bunch of methods out of `AttributeExt`	`24d84cd2fdff8c770fe4b151f5d84549e55fb14b` (link)
#165268	Fix constant-pattern equality suggestion spans in macros	`bb53c90c6ef55c91c5e72bb5f40214773955690c` (link)
#165318	Fix explicit destructor-call suggestion spans in macros	`d4c897dbd205f13731a7638e8e12767117dd01db` (link)
#164440	[Outreachy] alloc: Add test coverage for try_clone_from_ref…	`f927e5ee8dbc09a651913270ccf2990094c92fa5` (link)
#165001	Document allocator swap in BinaryHeap::append	`c422087c16f92dff0a67c2c2bc040e033d786b95` (link)
#165257	Revert FCW on lint attributes on macro calls	`1746b8556201c01b241e711e920bc600cef6a7b9` (link)
#165330	Impl read_le/read_be for f16 and f128	`c950c92143a2eb283b8463fd8285ddbde36d634f` (link)
#165364	Update books	`bb2f2096af759660601f9bfc9b4e75a71601210d` (link)
#165414	Remove unusued query key impl	`d8dfdd39d515be2c58ce3e3af476a6812c742c51` (link)
#165424	Update amdgpu datalayout for LLVM 24	`76905cb341c7a0eb991e92c5aa6f1c4381824e79` (link)
#165440	docker: bump node to v24.22.2 in shared script	`32cbc8f18143a31cf78d4e7e71170bac38a93fbf` (link)
#165443	Add `Discriminant::ord`	`14b1af66da4d8219cfe68af7d71d8decc5e5284b` (link)
#165445	Add an unstable option to increase the chain depth of the n…	`e8e0760db01f8ff1b641e61804ad450654d913e6` (link)

parent commit: 2d20b42b88

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

JonathanBrouwer · 2026-11-05T12:34:24Z

@rust-timer triage all

rust-timer · 2026-11-05T12:34:30Z

Running triage with 14 benchmarks

Triage only executes the benchmarks on rollup members, that were changed significantly on the rollup.
For this rollup, these benchmarks are:

cranelift-codegen-0.119.0
deref-sidebar-stress
derive
enum-stress
eza-0.21.2
include-blob
issue-88862
libc-0.2.172
regex-automata-0.4.8
ripgrep-14.1.1
ripgrep-14.1.1-nll
stm32f4-0.15.1
syn-2.0.101
tokio-1.53.1

#164752 `3d00a13` Apply the Cortex-A53 843419 CC mitigation to aarch64 targets

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.0%	[2.0%, 2.0%]	1

Binary size

This perf run didn't have relevant results for this metric.

#165011 `cf6e715` std: Clean up and improve errors for `is_*_feature_detected` macros

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#165376 `2fa775b` Add `Forget` trait feature gate

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.7%]	11
Regressions ❌ (secondary)	0.5%	[0.2%, 1.1%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.7%]	11

Max RSS (memory usage)

Results (secondary -1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-3.0%, -1.9%]	3
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#164482 `2865137` Remove the label starting with 0 in the test binary_asm_labels_allowed.rs

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.0%, 0.5%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.2%	[-2.2%, -2.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#165201 `24d84cd` Move a bunch of methods out of `AttributeExt`

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.7%	[0.7%, 2.7%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.7%	[0.7%, 2.7%]	2

Binary size

This perf run didn't have relevant results for this metric.

#165268 `bb53c90` Fix constant-pattern equality suggestion spans in macros

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.5%, secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-2.6%	[-3.4%, -2.0%]	4
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

Cycles

Results (secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

#165318 `d4c897d` Fix explicit destructor-call suggestion spans in macros

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.6%, -2.6%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.3%	[-4.3%, -4.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

#164440 `f927e5e` [Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc)

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.5%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#165001 `c422087` Document allocator swap in BinaryHeap::append

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-3.1%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Binary size

This perf run didn't have relevant results for this metric.

#165257 `1746b85` Revert FCW on lint attributes on macro calls

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.5%, secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-2.6%	[-3.0%, -2.1%]	3
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#165330 `c950c92` Impl read_le/read_be for f16 and f128

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#165364 `bb2f209` Update books

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.6%, -2.5%]	2
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#165414 `d8dfdd3` Remove unusued query key impl

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.5%, -2.3%]	2
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#165424 `76905cb` Update amdgpu datalayout for LLVM 24

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.7%, -2.0%]	3
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

#165440 `32cbc8f` docker: bump node to v24.22.2 in shared script

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-3.4%, -2.1%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

#165443 `14b1af6` Add `Discriminant::ord`

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.0%, 0.6%]	8
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.5%, secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.1%	[1.1%, 1.1%]	1
Improvements ✅ (primary)	-2.5%	[-2.5%, -2.5%]	1
Improvements ✅ (secondary)	-2.9%	[-3.1%, -2.7%]	3
All ❌✅ (primary)	-2.5%	[-2.5%, -2.5%]	1

Cycles

Results (secondary -6.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.3%	[-7.7%, -4.8%]	2
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

#165445 `e8e0760` Add an unstable option to increase the chain depth of the next solver overflow FCW

This perf run didn't have relevant results for the `instruction count` metric.

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-3.3%, -2.5%]	2
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

antoyo and others added 30 commits October 17, 2026 13:20

Remove the label starting with 0 in the test binary_asm_labels_allowe…

f7d8e4a

…d.rs 0-prefixed labels are not accepted anymore with GNU as, so this is necessary to make this test pass with rustc_codegen_gcc.

Apply reversible compiler driver flag for a53 mitigation when required

737930a

Retry linking if the linker doesn't support the A53 mitigation

d28c750

Omit the mitigation on Apple and Windows targets

0a217f2

Remove unnecessary calls to to_string_lossy()

8274e7a

Document allocator swap in BinaryHeap::append

4477617

Apply review suggestion for BinaryHeap::append docs

7b1da71

std: Add UI tests for feature detection macros

20ae3b6

It can be a bit tricky to follow these macros, but we still want to provide good diagnostics. Add tests making sure these don't change.

std: Add more documentation to the std_detect macros

51ff312

std: Simplify std_detect feature iteraion using a list

5f7505c

Rather than transmuting discriminants, use the macros to generate a list of all features that we can iterate instead. This also allows us to remove the sentinel `_last` entry.

Fix constant-pattern suggestion spans in macros

63f2b39

Move is_word

3f31c43

Move has_any_name

23a6fce

Move has_name

0052b00

Move path

d543d29

Move is_doc_comment

9f0606a

Move doc_str

89cded6

Move meta_item_list

1c36299

Move path_span

721a73a

Move value_span

d37a3bb

Move is_proc_macro_attr

b5d23e6

Move symbol_path

e6b9842

Rename GeneratedAttr::name to path, to support tool attributes

427fe59

Fix explicit destructor-call suggestion spans in macros

34c44aa

impl_from_endian_bytes for f16 and f128

f6db665

fmt

ce9a827

add f16, f128 feature

d239ae1

Update books

b534567

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 4, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 5, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Nov 5, 2026

Auto merge of #165464 - JonathanBrouwer:rollup-zjmCS7N, r=<try>

ef27372

Rollup of 17 pull requests try-job: test-aarch64-apple-macos-26-2

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 5, 2026

rust-bors Bot merged commit 70424d8 into rust-lang:main Nov 5, 2026
16 checks passed

rustbot added this to the 1.101.0 milestone Nov 5, 2026

rustbot added the perf-regression Performance regression. label Nov 5, 2026

Conversation

JonathanBrouwer commented Nov 4, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Nov 4, 2026

Uh oh!

JonathanBrouwer commented Nov 4, 2026

Uh oh!

maxdexh commented Nov 4, 2026

Uh oh!

This comment has been minimized.

jhpratt commented Nov 5, 2026

Uh oh!

rust-bors Bot commented Nov 5, 2026

Uh oh!

jhpratt commented Nov 5, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Nov 5, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Nov 5, 2026

Uh oh!

Uh oh!

github-actions Bot commented Nov 5, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 5, 2026

Overall result: ❌ regressions - please read:

Uh oh!

rust-bors Bot commented Nov 5, 2026

Uh oh!

JonathanBrouwer commented Nov 5, 2026

Uh oh!

rust-timer commented Nov 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

#164752 3d00a13 Apply the Cortex-A53 843419 CC mitigation to aarch64 targets

#165011 cf6e715 std: Clean up and improve errors for is_*_feature_detected macros

#165376 2fa775b Add Forget trait feature gate

#164482 2865137 Remove the label starting with 0 in the test binary_asm_labels_allowed.rs

#165201 24d84cd Move a bunch of methods out of AttributeExt

#165268 bb53c90 Fix constant-pattern equality suggestion spans in macros

#165318 d4c897d Fix explicit destructor-call suggestion spans in macros

#164440 f927e5e [Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc)

#165001 c422087 Document allocator swap in BinaryHeap::append

#165257 1746b85 Revert FCW on lint attributes on macro calls

#165330 c950c92 Impl read_le/read_be for f16 and f128

#165364 bb2f209 Update books

#165414 d8dfdd3 Remove unusued query key impl

#165424 76905cb Update amdgpu datalayout for LLVM 24

#165440 32cbc8f docker: bump node to v24.22.2 in shared script

#165443 14b1af6 Add Discriminant::ord

#165445 e8e0760 Add an unstable option to increase the chain depth of the next solver overflow FCW

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

JonathanBrouwer commented Nov 4, 2026 •

edited by rustbot

Loading

rust-timer commented Nov 5, 2026 •

edited

Loading

#164752 `3d00a13` Apply the Cortex-A53 843419 CC mitigation to aarch64 targets

#165011 `cf6e715` std: Clean up and improve errors for `is_*_feature_detected` macros

#165376 `2fa775b` Add `Forget` trait feature gate

#164482 `2865137` Remove the label starting with 0 in the test binary_asm_labels_allowed.rs

#165201 `24d84cd` Move a bunch of methods out of `AttributeExt`

#165268 `bb53c90` Fix constant-pattern equality suggestion spans in macros

#165318 `d4c897d` Fix explicit destructor-call suggestion spans in macros

#164440 `f927e5e` [Outreachy] alloc: Add test coverage for try_clone_from_ref_in (Box, Arc, Rc)

#165001 `c422087` Document allocator swap in BinaryHeap::append

#165257 `1746b85` Revert FCW on lint attributes on macro calls

#165330 `c950c92` Impl read_le/read_be for f16 and f128

#165364 `bb2f209` Update books

#165414 `d8dfdd3` Remove unusued query key impl

#165424 `76905cb` Update amdgpu datalayout for LLVM 24

#165440 `32cbc8f` docker: bump node to v24.22.2 in shared script

#165443 `14b1af6` Add `Discriminant::ord`

#165445 `e8e0760` Add an unstable option to increase the chain depth of the next solver overflow FCW