Repository navigation
Rollup of 6 pull requests - #165526
Closed
JonathanBrouwer wants to merge 18 commits into
Closed
Rollup of 6 pull requests#165526JonathanBrouwer wants to merge 18 commits into
JonathanBrouwer wants to merge 18 commits into
Conversation
… faster than Vec::retain_mut
```
error[E0107]: missing generics for struct `a::Foo`
--> $DIR/impl-block-missing-const-generics.rs:6:10
|
LL | impl Foo {}
| ^^^ expected 1 generic argument
|
note: struct defined here, with 1 generic parameter: `AHA`
--> $DIR/impl-block-missing-const-generics.rs:4:12
|
LL | struct Foo<const AHA: usize>{}
| ^^^ ----------------
help: add missing generic argument
|
LL | impl<const AHA: usize> Foo<AHA> {}
| ++++++++++++++++++ +++++
```
Previously we only suggested `Foo<AHA>` without the `impl<const AHA: usize>`.
``` error: the constant `N` is not of type `usize` --> $DIR/const-in-impl-fn-return-type.rs:12:32 | LL | fn func<const N: u32>() -> [(); N]; | ------------ ^^^^^^^ expected `usize`, found `u32` | | | found this const parameter | = note: the length of array `[(); N]` must be type `usize` ```
``` error: the constant `B` is not of type `usize` --> $DIR/check_const_arg_type_in_free_alias.rs:15:30 | LL | type ArrLen<const B: bool> = [(); B]; | ------------- ^^^^^^^ expected `usize`, found `bool` | | | found this const parameter | = note: the length of array `[(); B]` must be type `usize` ```
```
error: the constant `N` is not of type `usize`
--> $DIR/bad-subst-const-kind.rs:8:26
|
LL | impl<const N: u64> Q for [u8; N] {
| ------------ ^^^^^^^ expected `usize`, found `u64`
| |
| `N` defined here
|
= note: the length of array `[u8; N]` must be type `usize`
```
…sleywiser
Tweak output on misused `const` parameter to provide more context and more accurate suggestion
When missing `const` param in `impl`, provide complete suggestion:
```
error[E0107]: missing generics for struct `a::Foo`
--> $DIR/impl-block-missing-const-generics.rs:6:10
|
LL | impl Foo {}
| ^^^ expected 1 generic argument
|
note: struct defined here, with 1 generic parameter: `AHA`
--> $DIR/impl-block-missing-const-generics.rs:4:12
|
LL | struct Foo<const AHA: usize>{}
| ^^^ ----------------
help: add missing generic argument
|
LL | impl<const AHA: usize> Foo<AHA> {}
| ++++++++++++++++++ +++++
```
Previously we only suggested `Foo<AHA>` without the `impl<const AHA: usize>`.
Fix rust-lang#91119.
Point at `const` param declaration when constant is not expected type:
```
error: the constant `N` is not of type `usize`
--> $DIR/const-in-impl-fn-return-type.rs:12:32
|
LL | fn func<const N: u32>() -> [(); N];
| ------------ ^^^^^^^ expected `usize`, found `u32`
| |
| found this const parameter
|
= note: the length of array `[(); N]` must be type `usize`
```
…, r=maxdexh Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut` Per our conversation in rust-lang#164155 (comment) Let me know if I should adjust the wording of the doc update. r? @Mark-Simulacrum
update Enzyme submodule closes two issues: EnzymeAD/Enzyme#2195, and especially EnzymeAD/Enzyme#3043 @bors try jobs=dist-x86_64-linux,optional-test-x86_64-gnu-autodiff r? ZuseZ4
…ariant, r=estebank DFV: Reject `#[non_exhaustive]` on enum variants with default field values Fixes rust-lang#165143. Part of rust-lang#132162. r? estebank or compiler <sub>(No LLM was or will be used by me during the entire creation process of this PR)</sub>
…d-scope-types, r=fmease Remove unused `WhereEqPredicate` and `ScopeId` types This removes unused `WhereEqPredicate` and `ScopeId` types and related impls. Related PRs: - rust-lang#37764 - rust-lang#153513
Update books ## rust-lang/reference 1 commits in 3989fe91f1a601b51684a582ad17b2503f221787..a2ae66d7037cbedac68746b9510b24cc34b96d69 2026-11-04 23:41:08 UTC to 2026-11-04 23:41:08 UTC - Stabilize `#[optimize]` attribute (rust-lang/reference#2278)
rustbot
added
A-attributes
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
Rollup of 6 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
…uwer Rollup of 6 pull requests Successful merges: - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion) - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`) - #165503 (update Enzyme submodule) - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values) - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types) - #165519 (Update books)
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@bors yield |
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #165513. |
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 6, 2026
…uwer Rollup of 6 pull requests Successful merges: - #164775 (Tweak output on misused `const` parameter to provide more context and more accurate suggestion) - #165448 (Update `Vec::retain_unstable` docs to say that this method is generally faster than `Vec::retain_mut`) - #165503 (update Enzyme submodule) - #165505 (DFV: Reject `#[non_exhaustive]` on enum variants with default field values) - #165514 (Remove unused `WhereEqPredicate` and `ScopeId` types) - #165519 (Update books)
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot)Important For more information how to resolve CI failures of this job, visit this link. |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for df04626 failed: CI. Failed job:
|
rust-bors
Bot
added
the
S-waiting-on-author
rustbot
removed
the
S-waiting-on-review
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
constparameter to provide more context and more accurate suggestion #164775 (Tweak output on misusedconstparameter to provide more context and more accurate suggestion)Vec::retain_unstabledocs to say that this method is generally faster thanVec::retain_mut#165448 (UpdateVec::retain_unstabledocs to say that this method is generally faster thanVec::retain_mut)#[non_exhaustive]on enum variants with default field values #165505 (DFV: Reject#[non_exhaustive]on enum variants with default field values)WhereEqPredicateandScopeIdtypes #165514 (Remove unusedWhereEqPredicateandScopeIdtypes)r? @ghost
Create a similar rollup