Repository navigation
Conversation
this loses us a bit of safety in rmeta decoding, because we may end up trying to load fn arg idents for ctors
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@bors try @rust-timer queue potentially perf sensitive part of #158305 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Use `DefKind::is_fn_like` instead of hand-rolling it
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (0f08239): comparison URL. Overall result: no relevant changes - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 4.1%, secondary 1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 481.055s -> 481.508s (0.09%) |
Seemed a small reduction in complexity to me, and has some fun minor test improvements