Skip to content

Use DefKind::is_fn_like instead of hand-rolling it - #165553

Open
oli-obk wants to merge 1 commit into
rust-lang:mainfrom
oli-obk:push-oyumrnvplllr
Open

oli-obk wants to merge 1 commit into
rust-lang:mainfrom
oli-obk:push-oyumrnvplllr

Conversation

@oli-obk

@oli-obk oli-obk commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Seemed a small reduction in complexity to me, and has some fun minor test improvements

this loses us a bit of safety in rmeta decoding, because we may end up trying to load fn arg idents for ctors
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2026
@rustbot

rustbot commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 79 candidates
  • Random selection from 20 candidates

@oli-obk

oli-obk commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@bors try @rust-timer queue

potentially perf sensitive part of #158305

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 6, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Nov 6, 2026
Use `DefKind::is_fn_like` instead of hand-rolling it
@rust-bors

rust-bors Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 0f08239 (0f0823973a95fcd0dd4f236d06152c68e87c63c4)
Base parent: 249c1e4 (249c1e4e31111b54ad2483cfd4cea06c7020c653)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0f08239): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.1%, secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
4.1% [2.3%, 5.9%] 2
Regressions ❌
(secondary)
1.5% [1.5%, 1.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.1% [2.3%, 5.9%] 2

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 481.055s -> 481.508s (0.09%)
Artifact size: 406.29 MiB -> 406.30 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 6, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants