Rollup of 5 pull requests by JonathanBrouwer · Pull Request #165711 · rust-lang/rust

JonathanBrouwer · 2026-11-09T18:52:34Z

Successful merges:

rust-analyzer subtree update #165705 (rust-analyzer subtree update)
Fix passing non-pointer value to PlaceRef::new_sized in debug_poison_to_local #165053 (Fix passing non-pointer value to PlaceRef::new_sized in debug_poison_to_local)
Next solver unsize coercion diagnostics #165404 (Next solver unsize coercion diagnostics)
Avoid terminator: None in custom mir parser #165502 (Avoid terminator: None in custom mir parser)
Add LinkedList::allocator #165697 (Add LinkedList::allocator)

r? @ghost

Create a similar rollup

To be consistent with `include_str!`.

Just docs & meta changes

Helpful to navigate directly to docs from the github page.

closes rust-lang#10

This makes the double brackets somewhat unnecessary. Now they are just used to find the macro invocation, though we should be able to get that with the data in `Position`.

…explicit

@ghost

`rust-analyzer` subtree update Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@e5e7830. Created using https://github.com/rust-lang/josh-sync. r? @ghost

@dianqk

…e-ref, r=dianqk Fix passing non-pointer value to `PlaceRef::new_sized` in `debug_poison_to_local` The value passed to the first argument of `PlaceRef::new_sized` should be a pointer to a type with the layout of the second argument, not a value of the layout's type itself. r? @dianqk

…-diagnostics, r=ShoyuVanilla Next solver unsize coercion diagnostics Adds special casing to the diagnostics alike the `Unsize` one we already had previously in order to provide better outputs, since the language user does not know about CoerceUnsized. This affects mostly the next solver, which depends on this predicate in order to work while the old one didn't seem to register it, so it wouldn't generate this diagnostic. More information in [zulip](https://rust-lang.zulipchat.com/#narrow/channel/618216-t-types.2Fcall-for-participation/topic/fix.20next.20solver.20unsize.20coercion.20diagnostics/with/637054385).

…, r=hanna-kruppe Avoid terminator: None in custom mir parser First step towards replacing `Option<Terminator>` with `Terminator` in `BasicBlockData`. See [this thread](https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/vibe.20check.20-.20removing.20Option.20from.20Terminator/with/637588808) for more info. This is a slight restructuring of the custom mir parser that avoids creating dummy basic blocks that don't have terminators. More details in individual commits.

…r=nia-e Add LinkedList::allocator Added an api extension LinkedList::allocator the same way `Vec`, `VecDeque`, `BinaryHeap`, `BTreeMap` and `BTreeSet` have it. Tracking issue rust-lang#163177

JonathanBrouwer · 2026-11-09T18:53:02Z

@bors r+ p=5 force

rust-bors · 2026-11-09T18:53:05Z

📌 Commit d25092b has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-11-09T22:11:23Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 4m 7s
Pushing ac8310b to main...

github-actions · 2026-11-09T22:14:43Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7f56606 (parent) -> ac8310b (this PR)

Test differences

Show 180 test diffs

Stage 0

completions::record::tests::literal_struct_not_trigger_unreachable_path: [missing] -> pass (J0)
completions::record::tests::literal_variant_not_trigger_unreachable_path: [missing] -> pass (J0)
handlers::apply_demorgan::tests::regression_23609: [missing] -> pass (J0)
handlers::destructure_struct_binding::tests::wildcard_pat: [missing] -> pass (J0)
handlers::generate_documentation_template::tests::supports_fn_with_re_export: [missing] -> pass (J0)
handlers::generate_function::tests::add_function_with_generic_param_in_another_file: [missing] -> pass (J0)
handlers::invalid_pat_path_res::tests::fn_in_path_pattern: [missing] -> pass (J0)
handlers::invalid_pat_path_res::tests::static_in_path_pattern: [missing] -> pass (J0)
handlers::invalid_pat_path_res::tests::valid_const_and_unit_struct_in_pattern: [missing] -> pass (J0)
handlers::match_inherited_imm_ref_with_mut_ref_pat::tests::eat_outer_inherited_imm_ref_with_mut_pat: [missing] -> pass (J0)
handlers::move_bounds::tests::move_bounds_to_where_clause_assoc_type_alias: [missing] -> pass (J0)
handlers::move_bounds::tests::move_bounds_to_where_clause_type_alias: [missing] -> pass (J0)
handlers::type_mismatch::tests::issue_23528: [missing] -> pass (J0)
handlers::unresolved_associated_type::tests::unresolved_associated_type_generic_param: [missing] -> pass (J0)
handlers::unresolved_associated_type::tests::unresolved_associated_type_self: [missing] -> pass (J0)
inlay_hints::implicit_drop::tests::display_hint_only_for_drop_glue: [missing] -> pass (J0)
tests::diagnostics::assoc_item_ref_without_generics: [missing] -> pass (J0)
tests::regression::new_solver::coercion_lub_failed_obligations_does_not_panic: [missing] -> pass (J0)
tests::smoke_test_indent: [missing] -> pass (J0)
tests::test_expect_file: [missing] -> pass (J0)
tests::test_find_str_lit_len: [missing] -> pass (J0)
tests::test_format_patch: [missing] -> pass (J0)
tests::test_locate: [missing] -> pass (J0)
tests::test_patchwork: [missing] -> pass (J0)
tests::test_trivial_assert: [missing] -> pass (J0)
tests::type_pos::complete_traits_in_type_pos_edition_2018: [missing] -> pass (J0)
tests::type_pos::complete_traits_in_type_pos_edition_2021: [missing] -> pass (J0)
tests::type_pos::complete_traits_in_type_pos_edition_2021_with_dyn: [missing] -> pass (J0)

Stage 1

completions::record::tests::literal_struct_not_trigger_unreachable_path: [missing] -> pass (J1)
completions::record::tests::literal_variant_not_trigger_unreachable_path: [missing] -> pass (J1)
handlers::apply_demorgan::tests::regression_23609: [missing] -> pass (J1)
handlers::destructure_struct_binding::tests::wildcard_pat: [missing] -> pass (J1)
handlers::generate_documentation_template::tests::supports_fn_with_re_export: [missing] -> pass (J1)
handlers::generate_function::tests::add_function_with_generic_param_in_another_file: [missing] -> pass (J1)
handlers::invalid_pat_path_res::tests::fn_in_path_pattern: [missing] -> pass (J1)
handlers::invalid_pat_path_res::tests::static_in_path_pattern: [missing] -> pass (J1)
handlers::invalid_pat_path_res::tests::valid_const_and_unit_struct_in_pattern: [missing] -> pass (J1)
handlers::match_inherited_imm_ref_with_mut_ref_pat::tests::eat_outer_inherited_imm_ref_with_mut_pat: [missing] -> pass (J1)
handlers::move_bounds::tests::move_bounds_to_where_clause_assoc_type_alias: [missing] -> pass (J1)
handlers::move_bounds::tests::move_bounds_to_where_clause_type_alias: [missing] -> pass (J1)
handlers::type_mismatch::tests::issue_23528: [missing] -> pass (J1)
handlers::unresolved_associated_type::tests::unresolved_associated_type_generic_param: [missing] -> pass (J1)
handlers::unresolved_associated_type::tests::unresolved_associated_type_self: [missing] -> pass (J1)
inlay_hints::implicit_drop::tests::display_hint_only_for_drop_glue: [missing] -> pass (J1)
tests::diagnostics::assoc_item_ref_without_generics: [missing] -> pass (J1)
tests::regression::new_solver::coercion_lub_failed_obligations_does_not_panic: [missing] -> pass (J1)
tests::smoke_test_indent: [missing] -> pass (J1)
tests::test_expect_file: [missing] -> pass (J1)
tests::test_find_str_lit_len: [missing] -> pass (J1)
tests::test_format_patch: [missing] -> pass (J1)
tests::test_locate: [missing] -> pass (J1)
tests::test_patchwork: [missing] -> pass (J1)
tests::test_trivial_assert: [missing] -> pass (J1)
tests::type_pos::complete_traits_in_type_pos_edition_2018: [missing] -> pass (J1)
tests::type_pos::complete_traits_in_type_pos_edition_2021: [missing] -> pass (J1)
tests::type_pos::complete_traits_in_type_pos_edition_2021_with_dyn: [missing] -> pass (J1)
[ui] tests/ui/dst/unsize-coercion.rs#next: [missing] -> pass (J2)
[ui] tests/ui/dst/unsize-coercion.rs#old: [missing] -> pass (J2)
[ui (polonius)] tests/ui/dst/unsize-coercion.rs#next: [missing] -> pass (J3)
[ui (polonius)] tests/ui/dst/unsize-coercion.rs#old: [missing] -> pass (J3)

Stage 2

[ui] tests/ui/dst/unsize-coercion.rs#next: [missing] -> pass (J4)
[ui] tests/ui/dst/unsize-coercion.rs#old: [missing] -> pass (J4)

Additionally, 118 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ac8310ba643a3796cbe77d2e06944d7c8513999f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

test-x86_64-mingw-1: 1h 55m -> 3h 2m (+58.1%)
test-x86_64-gnu-llvm-22-3: 1h 19m -> 1h 57m (+48.4%)
test-i686-gnu-1: 1h 35m -> 2h 17m (+43.5%)
dist-sparcv9-solaris: 1h 12m -> 1h 40m (+38.8%)
test-arm-android: 1h 54m -> 1h 10m (-38.5%)
dist-arm-linux-gnueabi: 1h 37m -> 1h 2m (-35.7%)
test-x86_64-msvc-ext3: 1h 4m -> 1h 26m (+33.9%)
dist-powerpc64-linux-musl: 1h 40m -> 1h 9m (-31.2%)
dist-powerpc64le-linux-musl: 1h 41m -> 1h 10m (-30.8%)
dist-android: 36m 7s -> 25m 3s (-30.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-11-09T23:06:14Z

Finished benchmarking commit (ac8310b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[0.9%, 3.4%]	9
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.7%	[-5.7%, -5.7%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -0.2%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	3.0%	[2.1%, 4.6%]	6
Improvements ✅ (primary)	-2.4%	[-2.4%, -2.4%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-2.4%, 2.0%]	2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 483.422s -> 481.131s (-0.47%)
Artifact size: 406.22 MiB -> 406.14 MiB (-0.02%)

rust-bors · 2026-11-09T23:24:07Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#165705	`rust-analyzer` subtree update	`50694a337f540547134305667b9875a210e122bb` (link)
#165053	Fix passing non-pointer value to `PlaceRef::new_sized` in `…	`d218e88f8a65d822032cd0e8ba29e8bed719934b` (link)
#165404	Next solver unsize coercion diagnostics	`aefcb488ab3e81c0c0c1572bc62be3a49b94a044` (link)
#165502	Avoid terminator: None in custom mir parser	`a00a645d1fab1966d6aa4a24c4ebd4a262de38b0` (link)
#165697	Add LinkedList::allocator	`45ed458032462af5ff6d36f7ad0401f0da98ce3b` (link)

parent commit: 7f56606f4d

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

matklad and others added 30 commits August 21, 2020 12:35

Initial

d49dc92

Setup continious release

e0922a7

Switch expect_file to file-relative path

d5e3e4f

To be consistent with `include_str!`.

v1.0.0

48388b8

1.0.0 take 2

9e4964b

Fix repo link

41d83bf

Fix docs

552be0c

Publish 1.0.1

1370cb4

Just docs & meta changes

Fix diff direction

d6b4ed0

Show usage in readme

1bf0ebe

Minor doc improvements

3208df3

Use dissimilar for diffs instead of difference

9805d2e

Add a docs.rs link in the README

6d0c9e6

Helpful to navigate directly to docs from the github page.

Better example

dfa7790

allow disabling automatic indentation on update

19cdcc3

closes rust-lang#10

Respect user provided absolute path

cadc747

Improve error messaging

d155216

Bump version

fa26a9f

Consolidate absolute workspace path calculation

b61ad96

Actually produce absolute path

a66d92b

make it more production ready

64e10a4

update CI

eabddd7

Parse string literals to find their length.

bdfaf2c

This makes the double brackets somewhat unnecessary. Now they are just used to find the macro invocation, though we should be able to get that with the data in `Position`.

Account for whitespace between expect![[ and the literal

dbd5b07

don't rely on canonicalize

1413d33

dead code

8257b4d

MSRV compat

a7526b4

Allow consumers to bind expect to a different name

33082d2

Document support for renaming

1a9154b

Update documentation/messages to reflect single-delimiter support

ff4bb2f

panstromek and others added 6 commits November 9, 2026 17:38

add some asserts to custom mir parser to make some if its invariants …

c84c4c8

…explicit

Rollup merge of rust-lang#165705 - lnicola:sync-from-ra, r=lnicola

9a80587

`rust-analyzer` subtree update Subtree update of `rust-analyzer` to rust-lang/rust-analyzer@e5e7830. Created using https://github.com/rust-lang/josh-sync. r? @ghost

Rollup merge of rust-lang#165697 - whiplashvin:linkedlist-allocator, …

d25092b

…r=nia-e Add LinkedList::allocator Added an api extension LinkedList::allocator the same way `Vec`, `VecDeque`, `BinaryHeap`, `BTreeMap` and `BTreeSet` have it. Tracking issue rust-lang#163177

rust-bors Bot added the rollup A PR which is a rollup label Nov 9, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 9, 2026

rust-bors Bot merged commit ac8310b into rust-lang:main Nov 9, 2026
15 checks passed

rustbot added this to the 1.102.0 milestone Nov 9, 2026

This was referenced Nov 9, 2026

Don't emit no-op &T → &T reborrows #164014

Open

Implement cromulent Copy closure captures #163717

Draft

Reborrow &mut on every move #163494

Open

Navigation Menu

Repository navigation

Rollup of 5 pull requests - #165711

Rollup of 5 pull requests#165711
rust-bors[bot] merged 133 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-MxaY3y5

JonathanBrouwer commented Nov 9, 2026

Uh oh!

JonathanBrouwer commented Nov 9, 2026

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Nov 9, 2026

Uh oh!

Uh oh!

github-actions Bot commented Nov 9, 2026

Stage 0

Stage 1

Stage 2

Uh oh!

rust-timer commented Nov 9, 2026

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

JonathanBrouwer commented Nov 9, 2026

Uh oh!

JonathanBrouwer commented Nov 9, 2026

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Nov 9, 2026

Uh oh!

Uh oh!

github-actions Bot commented Nov 9, 2026

Test differences

Stage 0

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 9, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants