Repository navigation
Disable no_threads compiler errors for Trusty targets - #165728
Merged
rust-bors[bot] merged 1 commit intoNov 10, 2026
Merged
Conversation
rustbot
added
A-thread
Collaborator
|
r? @nia-e rustbot has assigned @nia-e. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
...hmm. ...no one does do anything wild like shove a |
Member
|
Yes, that'd be a bad idea. This approach is the right one, Trusty isn't the only target where concurrency exists but is incompatible with @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Nov 10, 2026
…, r=joboet Disable no_threads compiler errors for Trusty targets rust-lang#158782 introduced compile-time checks to verify that targets using the no-thread implementation of sync primitives are actually marked single-threaded. This broke the Trusty targets, which are not marked single-threaded but are using the no-threads implementations. Trusty userspace doesn't have threads, but we can't mark the target single-threaded because we need atomic operations for shared-memory IPC. This PR adds an exception to the `#[cfg]` on the `compile_error!` to allow Trusty to use the no-thread sync implementations. Fixes rust-lang#165596
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 10, 2026
…uwer Rollup of 8 pull requests Successful merges: - #158970 (Support underscore as associated const name in inherent impls) - #165192 (BPF: Define max/min atomic width per CPU version) - #165611 (Avoid terminator: None in MIR building) - #165749 (Improve duplicate attribute diagnostics for active built-in attributes) - #165762 (Fix `x bench library/std`) - #165726 ([rustdoc-frontend] Properly clear search state when sidebar link is clicked) - #165728 (Disable no_threads compiler errors for Trusty targets) - #165754 (rustdoc: Rename `--show-coverage` CLI flag into `--coverage`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 10, 2026
…uwer Rollup of 7 pull requests Successful merges: - #165192 (BPF: Define max/min atomic width per CPU version) - #165611 (Avoid terminator: None in MIR building) - #165749 (Improve duplicate attribute diagnostics for active built-in attributes) - #165762 (Fix `x bench library/std`) - #165726 ([rustdoc-frontend] Properly clear search state when sidebar link is clicked) - #165728 (Disable no_threads compiler errors for Trusty targets) - #165754 (rustdoc: Rename `--show-coverage` CLI flag into `--coverage`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 10, 2026
Rollup merge of #165728 - randomPoison:trusty-std-no-threads, r=joboet Disable no_threads compiler errors for Trusty targets #158782 introduced compile-time checks to verify that targets using the no-thread implementation of sync primitives are actually marked single-threaded. This broke the Trusty targets, which are not marked single-threaded but are using the no-threads implementations. Trusty userspace doesn't have threads, but we can't mark the target single-threaded because we need atomic operations for shared-memory IPC. This PR adds an exception to the `#[cfg]` on the `compile_error!` to allow Trusty to use the no-thread sync implementations. Fixes #165596
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#158782 introduced compile-time checks to verify that targets using the no-thread implementation of sync primitives are actually marked single-threaded. This broke the Trusty targets, which are not marked single-threaded but are using the no-threads implementations. Trusty userspace doesn't have threads, but we can't mark the target single-threaded because we need atomic operations for shared-memory IPC. This PR adds an exception to the
#[cfg]on thecompile_error!to allow Trusty to use the no-thread sync implementations.Fixes #165596