Repository navigation
Fix x bench library/std - #165762
Fix x bench library/std#165762
x bench library/std#165762Conversation
|
Some changes occurred in src/tools/enzyme cc @ZuseZ4 Some changes occurred in src/tools/cargo cc @weihanglo |
rustbot
added
F-autodiff
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
d9e61f5 to
dcaa2aa
Compare
|
Sorry for the pings, I committed my out of date submodules again r? reroll |
|
Error: Failed to set assignee to
Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
|
r? bootstrap |
| // Some std configuration exists in its own profile | ||
| (_, Mode::Std) => Some("dist"), | ||
| // Otherwise, bench with the default profile, never dev | ||
| (Kind::Bench, _) => None, |
There was a problem hiding this comment.
Testing and benchmarking shouldn't use the default profile. They should use the exact same profile (and all other cargo configs) as the standard library contained in the sysroot was compiled with.
There was a problem hiding this comment.
True, that behaviour was a relic from when bootstrap used to pass --release which cargo bench doesn't accept. I've removed that line so the profile should always match now
dcaa2aa to
3e405fc
Compare
|
r? kobzol Thanks! @bors r+ |
rust-bors
Bot
added
S-waiting-on-bors
…rary, r=Kobzol Fix `x bench library/std` Since rust-lang#149514, bootstrap was building std with the dist profile, but still using the default profile for `cargo bench`. This PR fixes that by ensuring that operations on std always use the dist profile.
…uwer Rollup of 8 pull requests Successful merges: - #158970 (Support underscore as associated const name in inherent impls) - #165192 (BPF: Define max/min atomic width per CPU version) - #165611 (Avoid terminator: None in MIR building) - #165749 (Improve duplicate attribute diagnostics for active built-in attributes) - #165762 (Fix `x bench library/std`) - #165726 ([rustdoc-frontend] Properly clear search state when sidebar link is clicked) - #165728 (Disable no_threads compiler errors for Trusty targets) - #165754 (rustdoc: Rename `--show-coverage` CLI flag into `--coverage`)
…uwer Rollup of 7 pull requests Successful merges: - #165192 (BPF: Define max/min atomic width per CPU version) - #165611 (Avoid terminator: None in MIR building) - #165749 (Improve duplicate attribute diagnostics for active built-in attributes) - #165762 (Fix `x bench library/std`) - #165726 ([rustdoc-frontend] Properly clear search state when sidebar link is clicked) - #165728 (Disable no_threads compiler errors for Trusty targets) - #165754 (rustdoc: Rename `--show-coverage` CLI flag into `--coverage`)
Rollup merge of #165762 - adamgemmell:dev/adagem01/bench-library, r=Kobzol Fix `x bench library/std` Since #149514, bootstrap was building std with the dist profile, but still using the default profile for `cargo bench`. This PR fixes that by ensuring that operations on std always use the dist profile.
Since #149514, bootstrap was building std with the dist profile, but still using the default profile for
cargo bench. This PR fixes that by ensuring that operations on std always use the dist profile.