Repository navigation
Rollup of 6 pull requests - #165821
Merged
Merged
Rollup of 6 pull requests#165821
Conversation
The macro was written to get around some suboptimal code generation. After the recent span compression overhaul it is no longer needed, and we can use a simpler type to achieve the same goal.
This is a part of the stack-protector stabilization The `-Z stack-protector=basic` mode (`-fstack-protector`) uses heuristics that are specifically designed to catch old-C-style string manipulation. This is not a good fit to Rust, which does not perform much unsafe C-style string manipulation. As far as I can tell, nobody has been asking for it, and few people are using it even in today's C - modern distros (e.g. Debian) tend to use `-fstack-protector-strong`. Therefore, `-Z stack-protector=basic` has been **removed**. If anyone is interested in it, they are welcome to add it back as an unstable option.
* std: don't overflow when rounding up huge thread stack sizes on unix * Update library/std/src/thread/tests.rs Co-authored-by: Joseph Zhao <65984904+programskillforverification@users.noreply.github.com> Co-authored-by: Ralf Jung <post@ralfj.de>
This was a cdb test that was failing locally when I updated Windows SDK to 10.0.28000.2957 (and thus cdb and WinDbg). Seems that for whatever reason eventual visualizations for `c` and `_box` changed between these cdb (WinDbg) versions.
Replace `match_span_kind` macro with `SpanKind` The macro was written to get around some suboptimal code generation. After the recent span compression overhaul it is no longer needed, and we can use a simpler type to achieve the same goal. r? @petrochenkov
…hread-stack-size, r=maxdexh std: don't overflow when rounding up huge thread stack sizes on unix This is a resubmission of rust-lang#165703 by lazerg. Fixes rust-lang#165683 r? maxdexh
Fix 'simga' typo in char.to_lowercase documentation It should be 'sigma'.
…=jieyouxu Update to ar_archive_writer 0.5.5 This includes rust-lang/ar_archive_writer#29, rust-lang/ar_archive_writer#39 and rust-lang/ar_archive_writer#40 together with 2 PRs that only apply to the CI config. Likely fixes rust-lang#151184 Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=2084582
…ic, r=jieyouxu Remove `-Z stack-protector=basic` This is a part of the stack-protector stabilization (pulled out from rust-lang#165704) The `-Z stack-protector=basic` mode (`-fstack-protector`) uses heuristics that are specifically designed to catch old-C-style string manipulation. This is not a good fit to Rust, which does not perform much unsafe C-style string manipulation. As far as I can tell, nobody has been asking for it, and few people are using it even in today's C - modern distros (e.g. Debian) tend to use `-fstack-protector-strong`. Therefore, `-Z stack-protector=basic` has been **removed**. If anyone is interested in it, they are welcome to add it back as an unstable option. r? @jieyouxu
…esleywiser Adjust `unsized.rs` debuginfo test expected output for cdb `10.0.28000.2957` This was a cdb test that was failing locally when I updated Windows SDK to `10.0.28000.2957` (and thus cdb and WinDbg). Currently our Windows CI seems to use Windows SDKs around `10.0.26100.*`. See example run: - rust-lang#165808 - => https://github.com/rust-lang/rust/actions/runs/43010199577 - => https://github.com/rust-lang/rust/actions/runs/43010199577/job/130488011527 - => Runner image `windows-2025-vs2026 20261103.298.1` - => https://github.com/actions/runner-images/blob/win25-vs2026/20261103.298/images/windows/Windows2025-VS2026-Readme.md - => `10.0.26100.33674` Seems that for whatever reason eventual visualizations for `c` and `_box` changed between these cdb (WinDbg) versions. For ```rs let c: &Foo<dyn std::fmt::Debug> = &Foo { value: 7i32 }; ``` the `10.0.26100.*` series seem to output e.g. ``` //@ cdb-check:c [Type: ref$<unsized::Foo<dyn$<core::fmt::Debug> > >] //@ cdb-check: [+0x000] pointer : 0x[...] [Type: unsized::Foo<dyn$<core::fmt::Debug> > *] //@ cdb-check: [...] vtable : 0x[...] [Type: unsigned [...]int[...] (*)[4]] ``` but `10.0.28000.2957` output changed to a single line e.g. ``` c : 7 [Type: i32 (derived from ref$<unsized::Foo<dyn$<core::fmt::Debug> > >)] ``` So likely one of: - Default visualizers got updated - WinDbg internals changed - cdb <-> WinDbg engine interactions changed I cannot find cdb/WinDbg changelogs anywhere for these specific Windows SDK versions, so the best I can do is use `10.0.28000.2957` output as new expected output and gate this test on a minimum cdb version of `10.0.28000.2957`. This of course means that, before our GHA windows runner images update to a Windows SDK that's at least `10.0.28000.2957` (and thus cdb since they're distributed and versioned together), this test will not run in CI.
rustbot
added
A-LLVM
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 11, 2026
Rollup of 6 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
This comment has been minimized.
This comment has been minimized.
Contributor
rust-bors
Bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 9f5e966 (parent) -> 3ef0c22 (this PR) Test differencesShow 28 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 3ef0c22cdb86ac42dc6b8f0f1ec36857daa6f2a1 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (3ef0c22): comparison URL. Overall result: ❌✅ regressions and improvements - please read:Our benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 3.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -3.0%, secondary 2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 484.648s -> 485.002s (0.07%) |
Contributor
|
📌 Perf builds for each rolled up PR:
parent commit: 9f5e966d58 In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
match_span_kindmacro withSpanKind#165805 (Replacematch_span_kindmacro withSpanKind)-Z stack-protector=basic#165812 (Remove-Z stack-protector=basic)unsized.rsdebuginfo test expected output for cdb10.0.28000.2957#165815 (Adjustunsized.rsdebuginfo test expected output for cdb10.0.28000.2957)r? @ghost
Create a similar rollup