Make `<*const T>::is_null` const fn by oli-obk · Pull Request #74940 · rust-lang/rust

oli-obk · 2020-07-30T10:28:47Z

cc @rust-lang/wg-const-eval

tracking issue: #74939

RalfJung · 2020-08-10T13:08:31Z

r=me with the last nits fixed and after squashing

bors · 2020-08-11T03:46:07Z

☔ The latest upstream changes (presumably #75383) made this pull request unmergeable. Please resolve the merge conflicts.

oli-obk · 2020-08-11T09:54:27Z

@bors r=RalfJung

bors · 2020-08-11T09:54:28Z

📌 Commit 34c3c0d has been approved by RalfJung

RalfJung · 2020-08-11T11:32:12Z

@@ -0,0 +1,16 @@
+// compile-flags: --crate-type=lib
+// check-pass


Are you sure check-pass is enough for this?

considering that it did cause stderr output when I had the asserts inverted, yes.

These constants are evaluated by the lint that used to be const_err, and check runs all lints.

bors · 2020-08-11T17:51:45Z

⌛ Testing commit 34c3c0d with merge 6495955293bc979b4b521db8cb744f36bba1fd6f...

bors · 2020-08-11T18:16:53Z

💔 Test failed - checks-actions

RalfJung · 2020-08-17T12:17:23Z

@oli-obk
this needs tests to be made compatible with 32bit.

-	   |                  inbounds test failed: pointer must be in-bounds at offset 16, but is outside bounds of alloc2 which has size 8
+	   |                  inbounds test failed: pointer must be in-bounds at offset 8, but is outside bounds of alloc2 which has size 4

oli-obk · 2020-08-17T13:33:21Z

@bors r=RalfJung

bors · 2020-08-17T13:33:22Z

📌 Commit daf7a37 has been approved by RalfJung

bors · 2020-08-17T14:13:19Z

⌛ Testing commit daf7a37 with merge e8df0b8...

bors · 2020-08-17T16:11:05Z

☀️ Test successful - checks-actions, checks-azure
Approved by: RalfJung
Pushing e8df0b8 to master...

rust-highfive assigned RalfJung Jul 30, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2020

This comment has been minimized.

Sign in to view

oli-obk force-pushed the const_is_null branch from 4029711 to e92c5e5 Compare July 30, 2020 12:40

RalfJung reviewed Jul 30, 2020

View reviewed changes

Comment thread src/librustc_mir/interpret/intrinsics.rs Resolved

oli-obk force-pushed the const_is_null branch from 5d56ed3 to 5b68b87 Compare July 31, 2020 17:50

RalfJung reviewed Aug 5, 2020

View reviewed changes

Comment thread src/librustc_mir/interpret/intrinsics.rs Resolved

RalfJung reviewed Aug 5, 2020

View reviewed changes

Comment thread src/librustc_mir/interpret/intrinsics.rs Resolved

RalfJung reviewed Aug 5, 2020

View reviewed changes

Comment thread src/librustc_mir/interpret/intrinsics.rs Resolved

RalfJung reviewed Aug 5, 2020

View reviewed changes

Comment thread src/librustc_mir/interpret/intrinsics.rs Resolved

Comment thread library/core/src/ptr/const_ptr.rs Resolved

Comment thread src/librustc_mir/interpret/intrinsics.rs Resolved

RalfJung reviewed Aug 6, 2020

View reviewed changes

Comment thread library/core/src/ptr/const_ptr.rs Resolved

RalfJung reviewed Aug 6, 2020

View reviewed changes

Comment thread src/librustc_mir/interpret/intrinsics.rs Resolved

RalfJung reviewed Aug 6, 2020

View reviewed changes

Comment thread src/librustc_mir/interpret/intrinsics.rs Resolved

RalfJung reviewed Aug 6, 2020

View reviewed changes

Comment thread library/core/src/ptr/const_ptr.rs Resolved

RalfJung reviewed Aug 6, 2020

View reviewed changes

Comment thread src/test/ui/consts/ptr_comparisons.rs Resolved

RalfJung reviewed Aug 6, 2020

View reviewed changes

Comment thread src/test/ui/consts/ptr_comparisons.rs Resolved

RalfJung reviewed Aug 7, 2020

View reviewed changes

Comment thread src/test/ui/consts/ptr_comparisons.rs Resolved

RalfJung reviewed Aug 10, 2020

View reviewed changes

Comment thread src/test/ui/consts/ptr_comparisons.rs Resolved

RalfJung reviewed Aug 10, 2020

View reviewed changes

Comment thread src/librustc_mir/interpret/intrinsics.rs Resolved

RalfJung reviewed Aug 10, 2020

View reviewed changes

Comment thread src/librustc_mir/interpret/intrinsics.rs Resolved

RalfJung reviewed Aug 10, 2020

View reviewed changes

Comment thread src/test/ui/consts/ptr_is_null.rs Resolved

oli-obk force-pushed the const_is_null branch from 1595732 to d4d0d3d Compare August 10, 2020 16:22

RalfJung added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 10, 2020

Make <*const T>::is_null const fn

34c3c0d

oli-obk force-pushed the const_is_null branch from d4d0d3d to 34c3c0d Compare August 11, 2020 09:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2020

RalfJung reviewed Aug 11, 2020

View reviewed changes

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2020

RalfJung added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2020

Make a test platform independent

daf7a37

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 17, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 17, 2020

bors merged commit e8df0b8 into rust-lang:master Aug 17, 2020

oli-obk deleted the const_is_null branch March 16, 2021 12:14

kennytm mentioned this pull request Oct 8, 2021

Tracking issue for const slice::from_raw_parts_mut (const_slice_from_raw_parts_mut) #67456

Closed

1 task done

cuviper added this to the 1.47.0 milestone May 2, 2024

clarfonthey added the A-raw-pointers Area: raw pointers, MaybeUninit, NonNull label Nov 4, 2026

		@@ -0,0 +1,16 @@
		// compile-flags: --crate-type=lib
		// check-pass

Conversation

oli-obk commented Jul 30, 2020 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RalfJung commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bors commented Aug 11, 2020

Uh oh!

oli-obk commented Aug 11, 2020

Uh oh!

bors commented Aug 11, 2020

Uh oh!

RalfJung Aug 11, 2020

Choose a reason for hiding this comment

Uh oh!

oli-obk Aug 11, 2020

Choose a reason for hiding this comment

Uh oh!

bors commented Aug 11, 2020

Uh oh!

bors commented Aug 11, 2020

Uh oh!

RalfJung commented Aug 17, 2020

Uh oh!

oli-obk commented Aug 17, 2020

Uh oh!

bors commented Aug 17, 2020

Uh oh!

bors commented Aug 17, 2020

Uh oh!

bors commented Aug 17, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

oli-obk commented Jul 30, 2020 •

edited by rustbot

Loading

RalfJung commented Aug 10, 2020 •

edited

Loading