[eholk]

When rustc is running without a lint tool such as clippy enabled, options for lints such as clippy::foo are meant to be ignored. This was already working for those specified by attrs, such as #![allow(clippy::foo)], but this did not work for command line arguments like -A clippy::foo. This PR fixes that issue.

Note that we discovered this issue while discussing rust-lang/cargo#5034.

Fixes #86628.

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

Does this mean we no longer need -- in cargo clippy -- -W clippy::lint?

Does this mean we no longer need -- in cargo clippy -- -W clippy::lint?

It shoudn't have any change there. This simply makes it so you can do rust -W clippy::lint without getting an error message.

The src/tools/rust-analyzer submodule update looks unintentional and needs to be removed.

Thanks for the comments, @petrochenkov. I removed the rust-analyzer submodule update.

@rustbot label -S-waiting-on-author +S-waiting-on-review

This is a little better now, although probably not quite ready to merge. I think there's some more cleanup still to do. Is it at least on the right path for solving the problem?

I'm also having an issue with my tests. Even after adding the .stderr file, I get the following failure. Any ideas?

unexpected errors (from JSON output): [
    Error {
        line_num: 1,
        kind: Some(
            Error,
        ),
        msg: "1:1: 1:1: unknown lint tool: `unknown_tool` [E0602]",
    },
    Error {
        line_num: 1,
        kind: Some(
            Error,
        ),
        msg: "1:1: 1:1: unknown lint tool: `unknown_tool` [E0602]",
    },
]

I'm also having an issue with my tests. Even after adding the .stderr file, I get the following failure. Any ideas?

The tests are missing //~ ERROR annotations.
Although, since the errors are not attached to spans you'll probably have to use // error-pattern: unknown lint tool: `unknown_tool` instead.

Tests need some adjustments, but otherwise LGTM.

Okay, this should be ready to go now.

@rustbot label -S-waiting-on-author +S-waiting-on-review

Thanks!
@bors r+

📌 Commit 4a83a93 has been approved by petrochenkov