Skip to content

Stabilize thread::is_finished - #95130

Merged
bors merged 2 commits into
rust-lang:masterfrom
workingjubilee:stably-finished
Mar 31, 2022
Merged

Stabilize thread::is_finished#95130
bors merged 2 commits into
rust-lang:masterfrom
workingjubilee:stably-finished

Conversation

@workingjubilee

@workingjubilee workingjubilee commented Mar 20, 2022

Copy link
Copy Markdown
Member

Closes #90470.

r? @m-ou-se

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 20, 2022
@m-ou-se

m-ou-se commented Mar 30, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Mar 30, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 5a25e22 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2022
@m-ou-se m-ou-se added the T-libs-api [DEPRECATED; DO NOT USE] label Mar 30, 2022
@m-ou-se m-ou-se mentioned this pull request Mar 30, 2022
Closed
7 of 8 tasks
@m-ou-se

m-ou-se commented Mar 30, 2022

Copy link
Copy Markdown
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 30, 2022
m-ou-se
m-ou-se reviewed Mar 30, 2022
View reviewed changes
Comment thread library/std/src/thread/scoped.rs Resolved
@m-ou-se

m-ou-se commented Mar 30, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Mar 30, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 25eb060 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 30, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 30, 2022
@Dylan-DPC
Rollup merge of rust-lang#95130 - workingjubilee:stably-finished, r=m…
99df494 
…-ou-se

Stabilize thread::is_finished

Closes rust-lang#90470.

r? `@m-ou-se`
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 30, 2022
Closed
@Dylan-DPC

Dylan-DPC commented Mar 30, 2022

Copy link
Copy Markdown
Member

potential failure of rollup

@Dylan-DPC

Dylan-DPC commented Mar 30, 2022

Copy link
Copy Markdown
Member

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 30, 2022
@m-ou-se

m-ou-se commented Mar 30, 2022

Copy link
Copy Markdown
Member

"warning: static variable statik should have an upper case name"

That seems unrelated. #94806 maybe?

@bors r+

@bors

bors commented Mar 30, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 25eb060 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 30, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 31, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2022
@bors
Auto merge of rust-lang#95506 - Dylan-DPC:rollup-b6kxzjc, r=Dylan-DPC
ffaf6f0 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#95130 (Stabilize thread::is_finished)
 - rust-lang#95263 (Restore `impl Future<Output = Type>` to async blocks)
 - rust-lang#95471 (Don't ICE when opaque types get their hidden type constrained again.)
 - rust-lang#95491 (Stabilize feature vec_retain_mut on Vec and VecDeque)
 - rust-lang#95497 (Spellchecking compiler comments)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 32c5a57 into rust-lang:master Mar 31, 2022
@rustbot rustbot added this to the 1.61.0 milestone Mar 31, 2022
@tmandry

tmandry commented Apr 29, 2022

Copy link
Copy Markdown
Member

@rustbot label +relnotes

@rustbot rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 29, 2022
@workingjubilee
workingjubilee deleted the stably-finished branch June 6, 2025 05:31
@clarfonthey clarfonthey added the A-thread Area: `std::thread` label Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

Assignees

@m-ou-se m-ou-se

Labels

A-thread Area: `std::thread` relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api [DEPRECATED; DO NOT USE]

Projects

None yet

Milestone

1.61.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for JoinHandle::is_finished

8 participants

@workingjubilee @m-ou-se @bors @Dylan-DPC @tmandry @rust-highfive @clarfonthey @rustbot