Repository navigation
Rustc pull update 2026-11-02 - #7226
Merged
Merged
Conversation
rustfmt subtree update 2026-10-22 Subtree update of `rustfmt` to rust-lang@b42f1d8. Created using https://github.com/rust-lang/josh-sync. rustc pull direction: rust-lang#7206 ## Notable PRs - rust-lang#6851 - rust-lang#7048 - rust-lang#7170 - rust-lang#7171 - rust-lang#7174 - rust-lang#7179 - rust-lang#7181 - rust-lang#7183 - rust-lang#7192 --- r? @ytmimi
Fixes rustfmt issue 7209
Now rustfmt shouldn't loose comments between braces when formatting
`cfg_select!` arms that use double brace syntax. For example,
```rust
cfg_select! {
_ => {
// after opening brace
{ x }
// before closing brace
}
}
```
rustfmt: prevent more comment loss in `cfg_select!` Fixes rust-lang#7209 Now rustfmt shouldn't loose comments between braces when formatting `cfg_select!` arms that use double brace syntax. For example, ```rust cfg_select! { _ => { // after opening brace { x } // before closing brace } } ``` Opening this up directly against r-l/r since losing comments in this context isn't great and we want the fix to land on nightly ASAP. r? @jieyouxu cc: @RalfJung
…uwer Rollup of 2 pull requests Successful merges: - rust-lang/rust#164800 (Use LLVMCreateBuilderForModule to create IR builders) - rust-lang/rust#164815 (rustfmt: prevent more comment loss in `cfg_select!`)
It's best to use `Span` methods because `SpanData` is mostly an internal detail, and to avoid unnecessary `SPAN_TRACK` calls. In the following cases, removing the `data()` gives identical behaviour: - `span.data().lo` --> `span.lo()` - `span.data().hi` --> `span.hi()` - `span.data().lo` + `span.data().hi` --> `span.lo_hi()` In the following case, removing the `data_untracked()` gives identical behaviour: - `span.data_untracked().parent` --> `span.parent()` In the following case, removing the `data` removes an unnecessary `SPAN_TRACK` call (because `SPAN_TRACK` is only needed for lo/hi accesses): - `span.data().ctxt` --> `span.ctxt()`
…r=Kivooeo Reduce `SpanData` use `SpanData` is mostly an internal detail, and using `Span` is preferable where possible. Details in individual commits. r? @Kivooeo
…uwer Rollup of 8 pull requests Successful merges: - rust-lang/rust#164955 (Use the updated buffer length in UEFI locate_handles) - rust-lang/rust#164958 (uefi: roll back env changes when `start_image` fails) - rust-lang/rust#164968 (thread_local::guard: update comments a bit) - rust-lang/rust#164303 (Remove the 'sub' method from 'At' and migrate to 'sub_raw') - rust-lang/rust#164674 (Use a NoSpan marker for region constraints without spans) - rust-lang/rust#164934 (Remove redundant vec and duplicate indexing in find_noop_landing_pads) - rust-lang/rust#164954 (Reduce `SpanData` use) - rust-lang/rust#164970 (`rust-analyzer` subtree update)
This updates the rust-toolchain.toml file to nightly-2026-11-02 (3e92e1a2d20b991ef23a6c6064c34d57ee8c98d3).
Pull recent changes from https://github.com/rust-lang/rust via Josh. Previous upstream ref: rust-lang/rust@1a2c479 New upstream ref: rust-lang/rust@3e92e1a Filtered ref: rust-lang/rustfmt@4bc2eb3 Upstream diff: rust-lang/rust@1a2c479...3e92e1a This merge was created using https://github.com/rust-lang/josh-sync.
jieyouxu
added
the
A-subtree-syncs
rustbot
added
the
S-waiting-on-author
3 tasks done
jieyouxu
marked this pull request as ready for review
November 2, 2026 11:42
rustbot
added
S-waiting-on-review
1 of 2 tasks
ytmimi
approved these changes
Nov 3, 2026
rustbot
added
release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Pull direction. Part of #7225.
See also #t-rustfmt > subtree sync ops @ 💬
Metadata
Merge ref '3e92e1a2d20b' (nightly-2026-11-02) from rust-lang/rust
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Previous upstream ref: rust-lang/rust@1a2c479
New upstream ref: rust-lang/rust@3e92e1a
Filtered ref: 4bc2eb3
Upstream diff: rust-lang/rust@1a2c479...3e92e1a
This merge was created using https://github.com/rust-lang/josh-sync.
Notable PRs
cfg_select!rust#164815Notes for the reviewer
max_widthwithin macros" (rust-lang/rustfmt#6651) and follow-up (rust-lang/rustfmt#7152) #7222.cfg_select!related merge conflicts; I resolved in favor of the changes in this side (rustfmt subtree) since that covers more of the edge cases.r? @ytmimi