Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With libc's 64-bit time configuration on 32-bit glibc,
timeval.tv_usecis 64-bit whilesuseconds_tremains 32-bit. Casting to the latter prevents socket2 from compiling. Infer the field's actual type instead, and check both i686 and armv7 time64 builds in CI.Fixes #684.
Validation: the all-targets/all-features compile regression fails on current master for i686 and armv7 with
--cfg=libc_unstable_time64, and passes with this change. Both targets and x86_64 also pass without the cfg; x86_64 passes with it.cargo test,cargo test --all-featuresin debug/release, formatting and strict Clippy pass locally. Cross targets were compile-checked, not executed.