Repository navigation
libssh2-sys: write relative paths in libssh2.pc - #366
Merged
Merged
Conversation
Root cause: build.rs substituted absolute OUT_DIR paths into the .pc and used placeholder names libssh2.pc.in no longer has, so Version, Requires and Libs kept literal @...@ tokens. libdir also pointed at lib/, while the archive is built into build/.
AlJohri
marked this pull request as ready for review
September 30, 2026 07:31
Collaborator
|
Thank you for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libssh2.pcrelative to${pcfiledir}instead of absoluteOUT_DIRpaths, so the build output is reproducible and relocatable.libdiratbuild/, wherelibssh2.ais actually written.libssh2.pc.inuses today (@LIBSSH2_VERSION@,@LIBSSH2_PC_*@); previouslyVersion:etc. held literal@...@tokens.Fixes #340