Skip to content

ci: Resolve all zizmor findings as of zizmor@1.31.1 - #157

Draft
hashcatHitman wants to merge 13 commits into
rust-lang:masterfrom
hashcatHitman:zizmor
Draft

hashcatHitman wants to merge 13 commits into
rust-lang:masterfrom
hashcatHitman:zizmor

Conversation

@hashcatHitman

Copy link
Copy Markdown
Member

In pursuit of getting more zizmor lints enforced across rust-lang repos through crabwatch, this PR fixes all zizmor findings as of zizmor@1.31.1, using the auditor persona. The lints that actually fired per-persona level are:

regular persona findings:

pedantic persona findings:

  • Everything from regular
  • Fixed in this PR:
  • Not fixed in this PR:
    • None

auditor persona findings:

  • Everything from pedantic
  • Not fixed in this PR:
    • None

The hash pin format is supported by tools like Dependabot and Renovate, which can update the pinned hashes and their associated comments. If you'd like help setting either of those up, let me know which you prefer, and if you'd like it in this PR or a new one. By default, I'd assume to set it up to only update GitHub Actions.

See: https://github.com/actions/checkout/releases/tag/v7.0.1

This is the same version we're already implicitly using.

Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
See: https://github.com/actions/cache/releases/tag/v6.1.0

This is the same version we're already implicitly using.

Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
@hashcatHitman

hashcatHitman commented Oct 31, 2026 •

Copy link
Copy Markdown
Member Author

The four failing tests are from changes I didn't make, but I'll see if I can fix them anyway.

Since the runner logs will only be around for so long, I'll record that they were failing like so:

$ rustup install ${env:RUSTUP_TOOLCHAIN} --profile minimal
error: toolchain 'nightly-i686-pc-windows-gnu' may not be able to run on this system
note: to build software for that platform, try `rustup target add i686-pc-windows-gnu` instead
note: add the `--force-non-host` flag to install the toolchain anyway

These were failing with the message:

```console
$ rustup install ${env:RUSTUP_TOOLCHAIN} --profile minimal
error: toolchain 'nightly-i686-pc-windows-gnu' may not be able to run on this system
note: to build software for that platform, try `rustup target add i686-pc-windows-gnu` instead
note: add the `--force-non-host` flag to install the toolchain anyway
```

Maybe it's really just that easy?

Signed-off-by: hashcatHitman <155700084+hashcatHitman@users.noreply.github.com>
@hashcatHitman

Copy link
Copy Markdown
Member Author

Hmmm, it isn't that easy. It looks like i686-pc-windows-gnu doesn't have host tools support anymore? I'm not sure what to do about that. Well, anyway, I've done what I can, and I'm leaving it in a better state than I found it in, so I guess this is okay for now.

@hashcatHitman

Copy link
Copy Markdown
Member Author

r? crabwatch

@hashcatHitman

Copy link
Copy Markdown
Member Author

Ok, no r? in this repo. I'll flip a coin. Heads=Marco.

@hashcatHitman

Copy link
Copy Markdown
Member Author
$ fend d2
  1: 50.00%  ##############################
  2: 50.00%  ##############################
$ fend roll 1d2
1

Looks like you won, @marcoieni!

@ChrisDenton

Copy link
Copy Markdown
Member

Hmmm, it isn't that easy. It looks like i686-pc-windows-gnu doesn't have host tools support anymore? I'm not sure what to do about that. Well, anyway, I've done what I can, and I'm leaving it in a better state than I found it in, so I guess this is okay for now.

I don't know how applicable it is to this repository but my solution for backtrace was to use an x86_64 host and then CARGO_BUILD_TARGET to set the i686 target. Admittedly that was for msvc rather than gnu.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: zizmor PR opened

Development

Successfully merging this pull request may close these issues.

2 participants