Repository navigation
winit-core: fix inverted RGBA size check for icons and cursors - #4826
Merged
ogoffart merged 1 commit intoNov 9, 2026
Merged
Conversation
smittie2000
changed the title
smittie2000
force-pushed
the
smittie2000/fix-rgba-size-check
branch
from
November 8, 2026 07:54
5bc95d0 to
fc2ec8d
Compare
c896b0a replaced `len % PIXEL_SIZE != 0` with `len.is_multiple_of(PIXEL_SIZE)` but dropped the negation, so `RgbaIcon::new` and `CustomCursorSource::from_rgba` rejected every valid buffer with `ByteCountNotDivisibleBy4`. Restore the negation and add tests for both constructors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
smittie2000
force-pushed
the
smittie2000/fix-rgba-size-check
branch
from
November 8, 2026 08:05
fc2ec8d to
7be4e6e
Compare
ogoffart
reviewed
Nov 9, 2026
ogoffart
left a comment
ogoffart
left a comment
Contributor
There was a problem hiding this comment.
oops. Apparently there were no tests :-(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
c896b0a ("Use is_multiple_of") replaced
rgba.len() % PIXEL_SIZE != 0withrgba.len().is_multiple_of(PIXEL_SIZE)but dropped the negation. Since thenRgbaIcon::newandCustomCursorSource::from_rgbareject every valid RGBA buffer withByteCountNotDivisibleBy4, and theapplicationexample panics on startup while loading its icon and cursors.This restores the
!in both places and adds unit tests for each constructor that accept a valid buffer and reject one with a partial pixel. The tests fail without the fix.Discovered while testing #4825 with the
applicationexample.🤖 Generated with Claude Code