Repository navigation
Add std::chrono::time_point constructor overloads and tests - #50
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This is now fixed, and if people accidentally introduce themselves somewhere else, someone from the community will move their post to the right channel. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
teor2345
left a comment
There was a problem hiding this comment.
Almost there, just need to tweak it to match the C++ overloads a bit more closely.
teor2345
left a comment
There was a problem hiding this comment.
Thanks, this looks good, let's move on to stage 2 of this task, using the instructions in the PR description.
Please create a new file with examples of failing overloads, the instructions for creating the stderr file are here:
overloading-macros/.github/workflows/check.yml
Lines 207 to 208 in 3e009c3
|
Just a reminder to move on to steps 2 & 3 in the PR description, and make sure they are up to date with your latest code changes. Applications must be submitted to Outreachy by Monday 9 November, please include this PR and any other Rust PRs you've done in that time. |
teor2345
left a comment
There was a problem hiding this comment.
This is mostly fine, just need to do code formatting.
Please move on to step 3, summarising the results of the analysis.
teor2345
left a comment
There was a problem hiding this comment.
Just need to fix a few things, let me know if you need help with this
Co-authored-by: teor <teor@riseup.net>
teor2345
left a comment
There was a problem hiding this comment.
Just going to tweak the whitespace here, then merge
|
Just reminding you that the Outreachy final application deadline is this Monday 9 November. You can include any Rust PR or ticket work you've done, it doesn't have to be merged (or reviewed) yet. Please submit a final application on the Outreachy website before Monday. The exact deadline is 4pm UTC, but it is better to submit early. You can edit your submitted application up until the deadline (and you can keep working on PRs after the deadline). |
Add C++
std::chrono::time_pointconstructors in Rust usingoverload!macro.Limitationsdoc sectionErgonomicsdoc sectionIncompatibilitiesdoc sectionWorkaroundsdoc sectionInexpressible Overloadsdoc section