Repository navigation
test(conformance): report multipart regression details - #1551
Conversation
Role review
|
CI evidenceRun 40962462759 on head |
overtrue
left a comment
There was a problem hiding this comment.
Reviewed d5a9c36 against main 06af380. No actionable finding in this test-only delta.
The reference report, baseline regression selection, family census, skip ratchet, recovered-case verdicts, fixture load and deadlines remain unchanged. The mapping preserves one entry per selected regression and adds only existing deny diagnostics, a missing-diagnostic marker or the skip reason. The Diagnostic formatter and CaseOutcome failure filter were inspected at this head.
Independent verification compiled the diagnostic function and exact diagnostic test with actual Diagnostic and CaseOutcome source in a standalone Rust harness; only the unrelated schema Violation shape was supplied locally. The control passed. Six separately compiled faults for omitted failure, included warning, wrong case ID, missing failure detail, omitted skip reason and missing skip reason marker each failed the assertion, and the restored control passed. git diff --check passed and the review worktree is clean. This check does not independently execute the live multipart family or the full local four-command gate.
Hosted CI run 40962462759 completed with all 33 jobs successful on this exact head. The original c-mpu-0015 failure remains unexplained in #1547; synthetic diagnostic controls and later green runs do not establish its cause or repair. Whole-command verifier latency remains tracked separately in #1504.
Role Verdicts
- simplicity-adversary: attacked baseline selection preservation, regression cardinality, deny-only filtering, missing observations and skipped-case reporting — no break found
Summary
Include each case's existing failing diagnostics in the multipart-family regression assertion. When details are absent, identify the missing diagnostic or the skip reason instead of reporting only a case ID. The baseline regression selection, case set, fixture load, assertions and deadlines are unchanged.
Related to #1547. This test-only diagnostic does not reproduce or fix the historical c-mpu-0015 failure. It is gateway-specific; no corresponding s3s change is identified.
Verification
On main
06af3805, with one Cargo build worker and incremental compilation disabled:cargo fmt --all --check: exit 0.cargo clippy --workspace --all-targets -- -D warnings: exit 0.cargo test --workspace: exit 0.cargo xtask verify --crate rustfs-gateway-conformance: exit 0 in 42.55 seconds wall time, with 24.67 seconds preparation and a 17.39-second checked loop. This exceeds the 30-second command target; see verify: conformance preparation exceeds command feedback budget #1504. An earlier base's complete invocation took 46.09 seconds.Role Verdicts
Breaking Change
Checklist
cargo xtask verify)went red. The PR description names which ones
BREAKINGand a migration pathunsafeintroducedinventory/linkmeintroduced#[non_exhaustive]added to a DTO