Repository navigation
Conversation
Collaborator
Author
Role Verdicts
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a feedback case fails, the assertion currently reports only the exit status, which does not identify the failing rule. Report the selected case ID, verdict, phase and deny rule names without emitting diagnostic messages or pointers. This is diagnostic instrumentation for #1549; it does not reproduce or fix the intermittent failure, and does not close the issue.
Verification
All commands used an executor-owned target. Workspace wall time includes a cold build and is not a CI gate measurement. The original signing feedback case passed in isolation. A temporary case status mismatch made the real feedback assertion fail with
expect/status, and was restored. Each of the three non-disclosure assertions and the exact summary assertion was separately mutated and observed failing. The earlier full library run overlapped an assertion-order edit and is not counted as a gate. Separate earlier candidate workspace failures in #1424 remain unexplained.Role Verdicts
IDs come from the local corpus and rule names from static producers; their String types do not enforce that invariant for future producers.
Breaking Change
Checklist
cargo xtask verify)BREAKINGand a migration pathunsafeintroducedinventory/linkmeintroduced#[non_exhaustive]added to a DTO