Repository navigation
Remove test certificates from published package - #261
Merged
Merged
Conversation
Collaborator
|
Thanks for the PR! I think this makes sense, the test certificates are heavy bloat. Would you mind rebasing on |
djc
approved these changes
Oct 26, 2026
The published version of `rustls-platform-verifier` contains a larger number of test-certificates, e.g https://crates.io/crates/rustls-platform-verifier/0.7.1/code/src/tests/verification_real_world/aws_amazon_com_valid_1.crt It would be good to exclude them from the published package to make reviewing the source code easier. This PR adds an explicit `include` statement to the `Cargo.toml` file to only include files that are needed to build the crate, not to run all tests. Specifically this PR removes the following files from the published package: ``` examples/update-certs.rs src/tests/ffi.rs src/tests/mod.rs src/tests/verification_mock/ca.go src/tests/verification_mock/go.mod src/tests/verification_mock/go.sum src/tests/verification_mock/mod.rs src/tests/verification_mock/root1-int1-ee_1-good.crt src/tests/verification_mock/root1-int1-ee_1-good.ocsp src/tests/verification_mock/root1-int1-ee_1-revoked.crt src/tests/verification_mock/root1-int1-ee_1-revoked.ocsp src/tests/verification_mock/root1-int1-ee_1-wrong_eku.crt src/tests/verification_mock/root1-int1-ee_127.0.0.1-good.crt src/tests/verification_mock/root1-int1-ee_127.0.0.1-good.ocsp src/tests/verification_mock/root1-int1-ee_127.0.0.1-revoked.crt src/tests/verification_mock/root1-int1-ee_127.0.0.1-revoked.ocsp src/tests/verification_mock/root1-int1-ee_127.0.0.1-wrong_eku.crt src/tests/verification_mock/root1-int1-ee_example.com-good.crt src/tests/verification_mock/root1-int1-ee_example.com-good.ocsp src/tests/verification_mock/root1-int1-ee_example.com-revoked.crt src/tests/verification_mock/root1-int1-ee_example.com-revoked.ocsp src/tests/verification_mock/root1-int1-ee_example.com-wrong_eku.crt src/tests/verification_mock/root1-int1.crt src/tests/verification_mock/root1.crt src/tests/verification_real_world/aws_amazon_com_valid_1.crt src/tests/verification_real_world/aws_amazon_com_valid_2.crt src/tests/verification_real_world/aws_amazon_com_valid_3.crt src/tests/verification_real_world/aws_amazon_com_valid_4.crt src/tests/verification_real_world/letsencrypt_org_valid_1.crt src/tests/verification_real_world/letsencrypt_org_valid_2.crt src/tests/verification_real_world/letsencrypt_org_valid_3.crt src/tests/verification_real_world/letsencrypt_org_valid_4.crt src/tests/verification_real_world/mod.rs src/tests/verification_real_world/revoked_badssl_com_1.crt src/tests/verification_real_world/revoked_badssl_com_1.ocsp src/tests/verification_real_world/revoked_badssl_com_2.crt ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published version of
rustls-platform-verifiercontains a larger number of test-certificates, e.g https://crates.io/crates/rustls-platform-verifier/0.7.1/code/src/tests/verification_real_world/aws_amazon_com_valid_1.crtIt would be good to exclude them from the published package to make reviewing the source code easier.
This PR adds an explicit
includestatement to theCargo.tomlfile to only include files that are needed to build the crate, not to run all tests.Specifically this PR removes the following files from the published package: