Skip to content

test: wait for settled reads in the unread filter walk test - #145

Merged
xsmyile merged 1 commit into
masterfrom
xsmyile/fix-unread-flake
Oct 6, 2026
Merged

xsmyile merged 1 commit into
masterfrom
xsmyile/fix-unread-flake

Conversation

@xsmyile

@xsmyile xsmyile commented Oct 6, 2026

Copy link
Copy Markdown
Member

The setsize check now retries until the in-flight read events land; the total always settles, so this is a test race, not a UI bug.

Closes #130

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes Reviewed the unread-filter forward-walk test adjustment and its asynchronous read-event handling.

  • Retry the exact count assertion. aria-setsize now uses an awaited toHaveAttribute assertion so pending read events can settle, while preserving the exact expected count and existing navigation checks.
  • Verification. The affected test passed 10 repetitions with four Chromium workers; the test server also completed TypeScript checking and the production frontend build.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@xsmyile
xsmyile merged commit 3841de8 into master Oct 6, 2026
3 checks passed
@xsmyile
xsmyile deleted the xsmyile/fix-unread-flake branch October 6, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ui): e2e 'unread filter › walks forward instead of snapping back to the top' is flaky

1 participant