Repository navigation
test: wait for settled reads in the unread filter walk test - #145
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the unread-filter forward-walk test adjustment and its asynchronous read-event handling.
- Retry the exact count assertion.
aria-setsizenow uses an awaitedtoHaveAttributeassertion so pending read events can settle, while preserving the exact expected count and existing navigation checks. - Verification. The affected test passed 10 repetitions with four Chromium workers; the test server also completed TypeScript checking and the production frontend build.
gpt-6.1-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The setsize check now retries until the in-flight read events land; the total always settles, so this is a test race, not a UI bug.
Closes #130