Skip to content

fix: keep reconciled and replayed lists in sync with the server - #149

Merged
xsmyile merged 1 commit into
masterfrom
xsmyile/fix-list-sync
Oct 6, 2026
Merged

xsmyile merged 1 commit into
masterfrom
xsmyile/fix-list-sync

Conversation

@xsmyile

@xsmyile xsmyile commented Oct 6, 2026

Copy link
Copy Markdown
Member

Reconcile: an in-place read kept only rows it had already loaded, so a new match between them (a message starred during a disconnect) was dropped. Replay: an arrival not on the fresh page was taken as new, but arrivals commit in order, so every one up to the last the read returned was already in its total.

Part of #129

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes Reviewed the UI and TUI list synchronization changes, regression tests, and the server ordering guarantees supporting arrival replay.

  • Held reconciliation: Replaces the server-confirmed loaded window, including newly matching rows between existing rows, while retaining an unresolved tail.
  • Arrival replay: Uses the last returned arrival as a watermark to avoid counting earlier committed arrivals twice in both clients.
  • Regression coverage: Adds exact row and total assertions for intermediate matches and arrivals beyond page or held-row limits.

Validation passed: all 155 message-store tests, all 75 TUI tests, and tsc -b. Browser tests and the full workspace suite were not run.

Pullfrog  | View workflow run | Using gpt-6.1-sol | 𝕏

@xsmyile
xsmyile merged commit 413804a into master Oct 6, 2026
3 checks passed
@xsmyile
xsmyile deleted the xsmyile/fix-list-sync branch October 6, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant