Repository navigation
fix: keep reconciled and replayed lists in sync with the server - #149
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the UI and TUI list synchronization changes, regression tests, and the server ordering guarantees supporting arrival replay.
- Held reconciliation: Replaces the server-confirmed loaded window, including newly matching rows between existing rows, while retaining an unresolved tail.
- Arrival replay: Uses the last returned arrival as a watermark to avoid counting earlier committed arrivals twice in both clients.
- Regression coverage: Adds exact row and total assertions for intermediate matches and arrivals beyond page or held-row limits.
Validation passed: all 155 message-store tests, all 75 TUI tests, and tsc -b. Browser tests and the full workspace suite were not run.
gpt-6.1-sol | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Reconcile: an in-place read kept only rows it had already loaded, so a new match between them (a message starred during a disconnect) was dropped. Replay: an arrival not on the fresh page was taken as new, but arrivals commit in order, so every one up to the last the read returned was already in its total.
Part of #129