Skip to content

Pass a version-gated isStreaming thunk to pi's markdown transform - #12

Open
onlurking wants to merge 1 commit into
rustytensor:mainfrom
onlurking:fix/isstreaming-thunk-compat
Open

onlurking wants to merge 1 commit into
rustytensor:mainfrom
onlurking:fix/isstreaming-thunk-compat

Conversation

@onlurking

Copy link
Copy Markdown

Description

pi 1.5.0 reads the render context's isStreaming through a thunk, so the patched renderer now supplies (() => component.isStreaming) on pi >=1.5 and the raw boolean below. Passing a boolean to 1.5.0 threw "isStreaming is not a function" during render and killed the process.

Closes #11

@onlurking
onlurking marked this pull request as draft November 2, 2026 16:12
pi 1.5.0 reads the render context's isStreaming through a thunk, so the
patched renderer now supplies (() => component.isStreaming) on pi >=1.5
and the raw boolean below. Passing a boolean to 1.5.0 threw
"isStreaming is not a function" during render and killed the process.

The gate reads the host's own version (VERSION export), treats an
unparseable version as "needs thunk", and the host smoke test now renders
a text block so the transform path runs against the matrix host. Adds pi
1.5.0 to the compatibility matrix.
@onlurking
onlurking force-pushed the fix/isstreaming-thunk-compat branch from e056796 to eeb098c Compare November 2, 2026 16:13
@onlurking
onlurking marked this pull request as ready for review November 2, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pi 1.5.0 crash: isStreaming is not a function in patched assistant renderer

1 participant