Repository navigation
Conversation
polycrit
force-pushed
the
sheremeta/packed-scatter-gather
branch
from
October 4, 2026 20:53
d4d527c to
64f48cb
Compare
polycrit
force-pushed
the
sheremeta/packed-static-bounds
branch
from
October 4, 2026 20:53
af2448b to
1404251
Compare
polycrit
force-pushed
the
sheremeta/packed-scatter-gather
branch
from
October 7, 2026 07:34
64f48cb to
1ee2897
Compare
polycrit
added a commit
that referenced
this pull request
Oct 8, 2026
polycrit
force-pushed
the
sheremeta/packed-static-bounds
branch
from
October 10, 2026 19:33
1404251 to
7308ae7
Compare
robin-p-schmitt
added a commit
that referenced
this pull request
Oct 14, 2026
… the result dim (port of #1867)
robin-p-schmitt
added a commit
that referenced
this pull request
Oct 14, 2026
# Conflicts: # returnn/frontend/_packed_backend.py # returnn/frontend/array_.py # tests/test_rf_packed.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes packed ops whose static, bound sized buffer could end up the wrong size under tracing, either because an op quietly changed the buffer's extent or because the size it proves for a new buffer was looser than it has to be. Covers
masked_select,scatter,gatherand packedconv.convwith stride 1 pads or slices its output buffer back to the input's total extent, so sibling buffers of the same layout stay the same length after the convmasked_select's static buffer bound also takes a declared capacity on the result dim into account, instead of always sizing from the source's full content boundmasked_select's result dim size is copied to the host, matching how other dim sizes live there, so combining it with another dim does not mix devices_total_boundscache remembers the tightest bound a packing over a dim has proven. A staticscatter's buffer size now takes the tightest of that bound, the declared capacity and the summed bounds of a dim's parts when it is a sumgather's static buffer size prefers a proven bound on the result dim over the capacity ratio between the two dims, since that ratio only holds when the result length tracks the source length, as with a stride or a windowTests