Repository navigation
Add role 300 to SUPPORTED_ROLES (end-user account, v1 API) - #116
Merged
Merged
Conversation
Signed-off-by: yaakov25 <yaakov@web.de>
sHedC
self-requested a review
October 25, 2026 19:01
sHedC
approved these changes
Oct 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 89.65% 89.65%
=======================================
Files 10 10
Lines 764 764
=======================================
Hits 685 685
Misses 79 79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@sHedC I tested with the patch and new role and it now works. So ready to release. Thank you! |
Owner
|
great thanks having some validation issues should resolve soon, every time they update HASS something does not work quite right :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Home Assistant integration fails with MasterthermUnsupportedRole: Role is not supported by this integration for my account.
My setup: pre-2022 heat pump (v1 API, mastertherm.vip-it.cz). Login via the official web portal and mobile app works fine. The login response (sanitized) is:
{"returncode":0,"message":"User logged in","modules":[{"id":"","module_name":"","config":[{"mb_addr":"1","mb_name":"unknown"}]}],"role":"300"}
This is a regular end-user account with a single own heat pump, so I believe 300 is a valid end-user role and should be accepted in SUPPORTED_ROLES. Happy to provide more details or testing if needed.