Skip to content

fix(server): validate title field in POST /api/projects #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jah-yee wants to merge 1 commit into from
Closed

fix(server): validate title field in POST /api/projects #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/server/src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ export function createApp(d: Deps): Hono<AppEnv> {

app.post("/api/projects", async c => {
const b = await body<{ repo?: string; folder?: string; title?: string; slug?: string }>(c)
const p = b.repo ? await d.lib.addRepo(b.repo, { title: b.title, slug: b.slug }) : b.folder ? d.lib.addFolder(b.folder, { title: b.title, slug: b.slug }) : null
if (b.title !== undefined && (typeof b.title !== "string" || !b.title.trim() || b.title.length > 80)) throw new AppError(400, "a title is 1 to 80 characters")
const p = b.repo ? await d.lib.addRepo(b.repo, { title: b.title?.trim(), slug: b.slug }) : b.folder ? d.lib.addFolder(b.folder, { title: b.title?.trim(), slug: b.slug }) : null
if (!p) throw new AppError(400, "give a GitHub repo (owner/name or URL) or a local folder")
// a repo this login can read but not push to: say so now, not at the first save
let warning: string | null = null
Expand Down