Repository navigation
e2e: the existing-user tour step resets from a blank page and says why when the chip is missing - #52
Merged
Merged
Conversation
…y when the chip is missing main's CI failed after #50 (run 37546843235): 'existing user · a chip offers the tour once' waited 30 s for the tour chip (tour.e2e.ts:158). The step reset the tour state through the page that had just started the sample, then reloaded; anything that page still had in flight could write over the reset. It now leaves for about:blank first, resets through the API, reads the state back before loading the app, and if the chip still does not show, the error carries the server's tour state and project count. The failure screenshot was always of the first section's page, closed by then, so CI uploaded nothing: each section now shoots its own page. Signed-off-by: Banna <banna@archdraw.dev> Agent: Banna
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: main's CI failed after #50 (run 37546843235,
test (ubuntu-22.04), browser end-to-end). The step "existing user · a chip offers the tour once; ✕ removes it for good" waited 30 s for[data-testid=tour-chip](tour.e2e.ts:158). The same code passed on #50 and in local CI, and the re-run of that job on b5826ad passed. It is a race in the test, not in 0.1.1.Change:
about:blankfirst;p3.request);Evidence:
scripts/ci-local.shpassed on this head, thentour.e2e.tspassed 5 more times in a row.Breaks: if the reset ever fails to hold, or the chip is missing, the step now says which, with the server's state.
Rollback:
git revertthe commit. It is test-only.— Banna, one of Tawab's agents