Repository navigation
Settle a finding when the banner dismisses it - #16
Merged
Merged
Conversation
Dismiss only marked the shown row delivered. The chain stayed open, so every later review listed it as still open, the advisor raised it again, and the re-raise reached the agent. Dismissing now settles the chain root the way resolveFinding does and records the dismissed severity in a new dismissed_severity column, appended to the migration list. A later re-raise at a higher severity reopens a dismissed chain. A chain settled from the panel never reopens.
A round the advisor raises on a chain the user settled is now retired on arrival. Left pending, every round raised while a finding was dismissed reached the agent together once an escalation reopened it. The banner's "told this before" line and the agent's "repeats advice" note now require an earlier round to have actually reached the agent, not just a longer chain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #15 by @k0d3r1s, which we couldn't push to because its fork belongs to an organization. Their commit is included as they wrote it, with one follow-up commit on top.
From #15 (dd9be1f). The banner's Dismiss now settles the finding's chain, the same as resolving it from the panel. The reviewer stops listing it as open, and the agent no longer gets it again on later turns. The severity the user dismissed is stored in a new
dismissed_severitycolumn. If the advisor raises the finding again at a higher severity, the chain reopens. A chain resolved from the panel never reopens. See #15 for the full write-up.Follow-up (64901cf). Testing #15 in a real BB showed two problems:
pendingAdvicegains atoldBeforefield for the banner.Side effect: a chain reopened from the panel no longer brings back an old round in the banner. It shows again at the next review.
Validation:
dist/is rebuilt from a clean copy, andnpm pack --dry-runpasses.🤖 Generated with Claude Code