Repository navigation
Release 0.1.7: findings language option - #19
Merged
salemsayed merged 2 commits intoOct 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advisor now offers a free-text Findings language setting under Settings → Extensions → Advisor. It controls finding titles, explanations and suggestions; plugin UI stays unchanged. Empty or whitespace keeps the existing prompt byte-for-byte. Thanks to @GEFNENEN for requesting this.
Closes #18.
Input is trimmed, capped at 40 Unicode characters, and JSON-encoded as language data with explicit instructions to ignore embedded commands. Structured result markers, field names, severity values, stable keys and sentinel values stay unchanged.
Independent Fable review in BB thread
thr_x328w5vtveapproved implementation commitaa0ce8fwith nits. This release applies only the two requested nits: remove the internal release handoff from the repository and rebuild dist in/tmp/advisor-build. The server bundle stays byte-identical; its source map no longer embeds the worker checkout path. The optional grapheme-cluster suggestion is deferred.Validation on Node 22.19.0:
npm run verify(strict typecheck, all 145 tests, locked BB 0.47.1 / SDK 0.6.79 build), andnpm pack --dry-run. Tests cover original-prompt byte equality, Chinese, bounded/escaped odd values, and native-setting-to-reviewer-spawn integration through the SDK harness.fixtures/chinese-prompt.txtcontains a full dry render. Live model compliance and a visual host settings check were not exercised. No plugin install or reload in Salem's bb.Release procedure follows 0.1.6: bump package.json and both package-lock root version fields, update CHANGELOG, rebuild and commit dist, verify/package-check, push the branch, open the release PR, merge with a merge commit, create annotated tag
v0.1.7at the merged main revision with messageAdvisor v0.1.7, push the tag and create the GitHub release without assets. The marketplace entry distributes this GitHub repository with range^0.1.0, so no marketplace entry change is required. No npm publish.Prior-release evidence: release commit
4a0c865, PR #17, merge commit2bd504786286a8b6fa7320f7a6d92a7c9fdfc839, annotated tagv0.1.6(messageAdvisor v0.1.6), and the GitHub release published 2026-10-28 without assets. Its CI passed and PR #17 recorded 139 tests. These steps are reconstructed from Git/GitHub records, not a recovered shell transcript.