Repository navigation
fix: un-ignore vendored theme's FontAwesome/Bootstrap JS files - #73
Merged
scriptautomate-bc merged 1 commit intoAug 21, 2026
Conversation
.gitignore's node_modules/ rule (meant for a top-level npm install,
from before the theme was vendored) also matched the theme's
*vendored* npm-mounted files at any depth:
_vendor/.../pydata-hugo-theme/node_modules/@fortawesome/.../all.min.js
_vendor/.../pydata-hugo-theme/node_modules/bootstrap/.../bootstrap.bundle.min.js
git silently skips ignored paths on `git add`, so every re-vendoring
commit this cycle quietly omitted these two files -- they existed
locally (from local npm ci runs) so local builds always looked fine,
but a fresh CI checkout never had them. The theme's
head/fontawesome.html and head/bootstrap-js.html partials wrap the
lookup in `{{ with resources.Get ... }}`, which silently emits
nothing when the resource is missing -- no build error, just a
deployed site missing the FontAwesome icon-kit JS and Bootstrap's JS
bundle (dropdowns) entirely. This is why CI reported success on the
build that's currently live and broken.
Narrow the gitignore rule to the repo root only (/node_modules/) and
force-add the two files. Confirmed via a full audit (diff of every
file on disk under _vendor/ vs every file git tracks there) that
these were the only two files affected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitignore's node_modules/ rule (meant for a top-level npm install, from before the theme was vendored) also matched the theme's vendored npm-mounted files at any depth:
_vendor/.../pydata-hugo-theme/node_modules/@fortawesome/.../all.min.js
_vendor/.../pydata-hugo-theme/node_modules/bootstrap/.../bootstrap.bundle.min.js
git silently skips ignored paths on
git add, so every re-vendoring commit this cycle quietly omitted these two files -- they existed locally (from local npm ci runs) so local builds always looked fine, but a fresh CI checkout never had them. The theme's head/fontawesome.html and head/bootstrap-js.html partials wrap the lookup in{{ with resources.Get ... }}, which silently emits nothing when the resource is missing -- no build error, just a deployed site missing the FontAwesome icon-kit JS and Bootstrap's JS bundle (dropdowns) entirely. This is why CI reported success on the build that's currently live and broken.Narrow the gitignore rule to the repo root only (/node_modules/) and force-add the two files. Confirmed via a full audit (diff of every file on disk under _vendor/ vs every file git tracks there) that these were the only two files affected.