fix: resolve the P3 issues - #186
Conversation
Fixes wrong data, leaked values and broken setups found in the issue sweep: signal history, NgRx restore, forms selects, router labels and large route configs, pipe and Analog redaction, HTTP fault rules, Analog hydration and Nx routes, build-meta, mount path, popup server detection, extension panel after worker idle, Vite restart, HTTPS, WebSocket guard and base handling, hub restarts, static report scans and the build output guard. Docs are updated to match. Fixes santoshyadavdev#63, santoshyadavdev#64, santoshyadavdev#65, santoshyadavdev#66, santoshyadavdev#67, santoshyadavdev#68, santoshyadavdev#69, santoshyadavdev#70, santoshyadavdev#71, santoshyadavdev#72, santoshyadavdev#73, santoshyadavdev#74, santoshyadavdev#75, santoshyadavdev#76, santoshyadavdev#77, santoshyadavdev#78, santoshyadavdev#79, santoshyadavdev#80, santoshyadavdev#81, santoshyadavdev#82, santoshyadavdev#83, santoshyadavdev#84
Rebuilds extension/ui so the bundled panel matches the app changes for the NgRx restore banner, router truncation and server detection.
Restoring a state or pressing Back to latest removed the focused control, so focus fell to the page body. Focus now moves to the Back to latest button or the State tree, and the banner no longer repeats the status message.
At 360px the floating panel stayed 720px wide and cut off the no server message and the toolbar. The panel is now clamped to the window, the message scrolls, is announced through a status line and has a heading, and the setup link says it opens a new tab.
Rebuilds extension/ui so the bundled panel includes the store inspector focus fix.
Fixes wrong or missing data, accessibility gaps, redaction gaps and limits across forms, SSR and HTTP, injectors, NgRx, signals, components, overlay, router, Analog, pipes, the CLI and config, and adds panel tests and an axe check to CI. Also adds the features the P2 issues asked for: defer blocks, element picking, component properties, action origins, resource entries and change detection recording. Docs are updated to match. Refs santoshyadavdev#100, santoshyadavdev#102, santoshyadavdev#128 Fixes santoshyadavdev#85, santoshyadavdev#86, santoshyadavdev#87, santoshyadavdev#88, santoshyadavdev#89, santoshyadavdev#90, santoshyadavdev#91, santoshyadavdev#92, santoshyadavdev#93, santoshyadavdev#94, santoshyadavdev#95, santoshyadavdev#96, santoshyadavdev#97, santoshyadavdev#98, santoshyadavdev#99, santoshyadavdev#101, santoshyadavdev#105, santoshyadavdev#106, santoshyadavdev#107, santoshyadavdev#108, santoshyadavdev#109, santoshyadavdev#110, santoshyadavdev#111, santoshyadavdev#112, santoshyadavdev#113, santoshyadavdev#114, santoshyadavdev#115, santoshyadavdev#116, santoshyadavdev#117, santoshyadavdev#118, santoshyadavdev#119, santoshyadavdev#121, santoshyadavdev#122, santoshyadavdev#123, santoshyadavdev#124, santoshyadavdev#125, santoshyadavdev#126, santoshyadavdev#127, santoshyadavdev#129, santoshyadavdev#130, santoshyadavdev#131, santoshyadavdev#132, santoshyadavdev#133, santoshyadavdev#134, santoshyadavdev#135, santoshyadavdev#136, santoshyadavdev#137, santoshyadavdev#138, santoshyadavdev#139, santoshyadavdev#140, santoshyadavdev#141, santoshyadavdev#142, santoshyadavdev#143, santoshyadavdev#144, santoshyadavdev#145, santoshyadavdev#146, santoshyadavdev#147, santoshyadavdev#148, santoshyadavdev#149, santoshyadavdev#150, santoshyadavdev#151, santoshyadavdev#152, santoshyadavdev#153, santoshyadavdev#154, santoshyadavdev#155, santoshyadavdev#156, santoshyadavdev#158, santoshyadavdev#159
Rebuilds extension/ui so the bundled panel includes the P2 panel changes.
Fixes smaller data, wording and accessibility gaps across NgRx, forms, HTTP mocks, components, injectors, router and signals, and adds the features the P3 issues asked for: NgRx dispatch from the panel and an agent tool, service dependencies in the injector tree, outlet data, the change detection mode, signal jump links and a docs page for Hono, h3 and Fastify. Docs are updated to match. Fixes santoshyadavdev#160, santoshyadavdev#161, santoshyadavdev#162, santoshyadavdev#163, santoshyadavdev#165, santoshyadavdev#167, santoshyadavdev#168, santoshyadavdev#169, santoshyadavdev#170, santoshyadavdev#171, santoshyadavdev#172, santoshyadavdev#173, santoshyadavdev#174, santoshyadavdev#175, santoshyadavdev#176, santoshyadavdev#177, santoshyadavdev#178, santoshyadavdev#179, santoshyadavdev#180, santoshyadavdev#182, santoshyadavdev#183
Rebuilds extension/ui so the bundled panel includes the P3 panel changes.
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 14 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. Your 57 included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (94)
Comment |
|
View your CI Pipeline Execution ↗ for commit 00b8e76
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Canonicalizes paths in the build output guard, keeps select writes on the option-matching path for multiple and object-valued selects, redacts text before clipping it, counts left-out child routes and warns about truncation in every router tool mode, stops treating an Nx root Analog dependency as proof an app uses Analog, finds the Nx workspace output on its own, replaces any types in build-meta, checks values before reusing a signal history binding, and keeps focus after restoring the newest NgRx action.
Rebuilds extension/ui for the store inspector focus change.
Brings in the review fixes from santoshyadavdev#184. Keeps the P2 panel test setup and moves the P1 store inspector test onto it.
Brings in the santoshyadavdev#184 review fixes through P2. Keeps both store inspector panel tests (the focus test moves to store-inspector-focus.test.ts) and adds the paused flag next to the dispatch result entry.
…aces The Routes tab, get-routes and the Dashboard SSR and Analog fields resolved the Analog app from the working directory, so in an Nx workspace with several Analog apps they described the first app under apps/ instead of the one Vite serves. They now share the Vite root with the Analog tab through servedAnalogRoot().
Redacts the page URL and title in component tree reports, holds change detection instances weakly, stops visibility reports after pagehide so closed tabs are not counted as background tabs, points aria-controls at the response preview only while it is open, focuses the URL pattern after adding a rule, lets the panel find __connection.json next to itself so the CLI Panel URL and a report served at / connect, keeps refusing the folder the build was run from when --root is set, and fixes the tool count in the tools docs.
Rebuilds extension/ui for the network inspector and base URL changes.
Brings in the Vite root fix for Analog routes and build meta, keeping the P2 server function names.
Decodes escapes in NgRx action types read from source, words the dropped reason so it covers Store DevTools commit, reset and import, clears panel highlights when the panel closes, reloads or disconnects, and lists each service dependency once in the injector tree.
Rebuilds extension/ui for the panel highlight and store inspector changes.
Brings in the P2 QA fixes. Keeps component page URL redaction with the truncation reason, and clears the call log before pageshow in the signal page test, since the page now pushes right away when it comes back.
Decides the Back to latest focus from the finished restore response, accepts pending select values on controls that update on blur or submit, names the served Analog app in Nx workspaces, and marks strings cut by the redaction window as truncated.
Rebuilds extension/ui for the store inspector focus change.
Brings in the second round of santoshyadavdev#184 review fixes and rebuilds extension/ui.
Brings in the second round of santoshyadavdev#184 review fixes. Moves the new deferred restore focus test into store-inspector-focus.test.ts, where the P1 focus tests live on this branch, and rebuilds extension/ui.
Brings in the squashed santoshyadavdev#184 and santoshyadavdev#185 and the santoshyadavdev#187 and santoshyadavdev#188 docs changes. This branch already held every santoshyadavdev#184 and santoshyadavdev#185 commit, so the conflicts keep this branch's side.
Fixes the open P3 issues from the September sweep, with tests for each fix and docs updated to match. Based on #185 (P2), which is based on #184 (P1), so merge those first.
Closes #160
Closes #161
Closes #162
Closes #163
Closes #165
Closes #167
Closes #168
Closes #169
Closes #170
Closes #171
Closes #172
Closes #173
Closes #174
Closes #175
Closes #176
Closes #177
Closes #178
Closes #179
Closes #180
Closes #182
Closes #183
NgRx and agents
Docs
initNgDevtoolsHub()already returns a webhandler. Added a docs page for Hono, h3 and Fastify (apps/docs/src/content/getting-started/other-servers.md) covering the catch-all route underdevtools.base, the 404-outside-base behaviour and the transport choice (ws: false, sidecar, orattach(server)). It is linked from the nav, the introduction and the Express page. Added a Hono router test in hub.test.ts, withhono4.13.8 as a devDependency.debugName, but the compiler's implicit_signal_debug_name transform adds one in dev builds, and a failed write hook gave no sign. The Exact and sampled values section and the FAQ now describe the real causes.installSignalWriteHooknow returns null when the hook is missing, the overlay pusheswriteHook: false, and the panel shows a status notice.Forms and HTTP
Components and injectors
Router
Signals and panel
.rel-linkbutton with the label 'Go to '. jumpTo() selects the node (or the resource that owns an internal signal), clears the name and kind filters if they hide it, says so in a persistent role=status note, then scrolls the card into view and focuses it. The hover style is gone from the static internals rows. New signal-jump.test.ts fails before the fix and passes after, and signals.md is updated.availableTabs(the config-based list) andtabs, which shows only Dashboard plus the open tab until rpc is set. The Dashboard hides its stat cards and shows an aria-busy Configuration block saying Loading… until it connects. New app/src/tests/config-pending.test.ts fails before the fix and passes after, and dashboard.md is updated.forget-signal-pageaction (mapped tosignalsin RPC_INSPECTOR). It movesdraft.graphto the most recent page that is left. leave() calls it and resets lastSignalKey and historyDelta so a page restored from the back/forward cache pushes the full graph again. Tests are in agent-tools.test.ts and overlay-config.test.ts.Left open
Notes for review
#tab=link, not Dashboard alonehonois a new dev dependency (for the Hono hub test)Checks
pnpm test:devtools: 1040 tests passpnpm test:panel: 65 tests passpnpm test:axe: 0 violations in light and darkpnpm exec nx test angular-devtools,pnpm typecheck,pnpm format:check,pnpm skills:check, docs build: passextension/uirebuilt in its own commit