fix(router): block probe when router actions are off - #194
Merged
erkamyaman merged 2 commits intoOct 1, 2026
Merged
Conversation
Probe runs the app's canMatch guards and starts a navigation, but actions.router: false only blocked navigate, abort and replay in the panel, while agents lost the whole navigate tool, including instrument and resolve-lazy. Probe is now a router write action for both: the panel disables Probe in app with the config hint, and the agent tool refuses navigate, abort, replay and probe per call while instrument and resolve-lazy keep working. The docs say probe runs canMatch guards. Fixes santoshyadavdev#128
Rebuilds extension/ui for the disabled Probe in app button.
Contributor
|
Warning Review limit reachedEnable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Next included review available in 31 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 60 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
Comment |
github-actions
Bot
added
area: panel
|
View your CI Pipeline Execution ↗ for commit d760bff
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
erkamyaman
added a commit
to erkamyaman/angular-devtools
that referenced
this pull request
Oct 1, 2026
Brings in santoshyadavdev#189, santoshyadavdev#191, santoshyadavdev#193 and santoshyadavdev#194. Keeps the one-path loop paragraph next to the new Routes lab sentence in the router docs, adds the santoshyadavdev#194 upgrade note to the 0.0.6 changelog, and rebuilds extension/ui.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions: { router: false }now blocks Probe in app too, for the panel and for agents alike.Probe runs the app's
canMatchguards and starts a navigation, so it counts as a write. Before this, the panel only blocked navigate, abort and replay, while agents lost the wholenavigatetool, including Record each guard and resolver (instrument) andresolve-lazy, which only observe or load code.navigatetool stays registered and refusesnavigate,abort,replayandprobeper call whenactions.routeris off;instrumentandresolve-lazykeep working.agent.readOnlystill drops the whole tool, like the forms tool.Fixes #128
Checks
config.test.ts,router-mcp.test.tsandrouter-panels.test.ts; each fails without the fixpnpm test:devtools(1066),pnpm test:panel(71),pnpm test:axe,pnpm typecheck,pnpm format:check,pnpm skills:checkand the docs build passextension/uirebuilt in its own commit