fix(admin): enable Edit — Channels list rows now navigate to object page - #2163
Merged
Conversation
Row-click on Channels / ChannelCollections / ChannelTopicMap list reports did not navigate to the object page, so Edit was unreachable. The FE ListReport target was missing the navigation block that wires the list to its ObjectPage route (console: "creation mode 'NewPage' is used but the navigation configuration to the sub page is missing" + "storeInnerAppStateAsync is not a function"). Adds the navigation block to each ListReport settings, matching the working Concepts component pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tom: "I can create and delete channels but there is no edit available… I can't even navigate to the Object page. That's the root of the problem."
Clicking a row in the Channels, ChannelCollections, or ChannelTopicMap admin list reports did nothing — the URL stayed on the list route, so the ObjectPage (and its Edit button) was unreachable.
Root cause
All three Fiori Elements ListReport targets were missing the
navigationblock that wires a list to its ObjectPage route. Live console showed:The creation mode 'NewPage' is used but the navigation configuration to the sub page is missingTypeError: i.storeInnerAppStateAsync is not a functionThe working Concepts component has this block; the channel components did not.
Fix
Add the
navigationblock to each ListReport target'soptions.settings:ChannelsObjectChannelCollectionsObjectChannelTopicMapObjectDraft is already enabled on all three entities (
@odata.draft.enabled, cuid UUID keys), so Edit works once navigation reaches the object page.Testing
jq.--skip-build/-m; Step 3.5 bundle gate) + post-deploy click-through on DEV to confirm row→object→Edit.