Repository navigation
Fix #221 — stem a middle-line note the way the stem before it went - #226
Merged
Merged
Conversation
An unbeamed note on the middle line in an `.auto` voice now follows the previous stem in its part (the `lastStemUp` state #218 threads through pages, systems and measures), and stems up where there is none — the same tie-break as an even beam group, and what abcm2ps 8.14 does. It carries across bar lines and rests. `stem=`, pipe format and a shared staff's opposition still decide outright. The Canzonetta snapshot changes in three stems, each a B following a down stem; abcm2ps stems all three down. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #221
What
An unbeamed note on the middle line, when its voice's stems are left to the notes (
.auto), now stems the same way as the stem before it in that part. It goes up when there is none. This is the tie-break #218 uses for a beam group that sits as far above the middle line as below, and it reads the samelastStemUpstate. The rule carries across bar lines and rests.stem=,%%ceolkit:pipeformatand a shared staff's opposition still decide outright.Tests
Three new tests in
BeamGroupStemTests:stem=still deciding a middle-line noteEvery expected direction was checked against
abcm2ps -g(8.14).The Canzonetta page snapshot changes in three stems: alto
c2BG, sopranoc3B, and sopranoB2afterf_dec. Each is a B after a down stem, and abcm2ps stems all three down.🤖 Generated with Claude Code