This repository was archived by the owner on Oct 21, 2026. It is now read-only.
Repository navigation
Fix #33 - stop registering CeolKit fonts - #34
Merged
Merged
Conversation
The preview renders with CeolKit's default TextRendering.outlines, which writes glyphs into the SVG as paths, so SVGKit never resolves a font by family name and process font registration has no effect. Remove the CeolKitFonts.register() calls from app startup and the ScorePreviewView preview, and drop the test that only checked the registration. The remaining tests, which guard the preview's font independence, move to PreviewFontIndependenceTests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33
Summary
The preview renders with CeolKit's default
TextRendering.outlines. That writes every glyph into the SVG as a<path>, so SVGKit never looks up Bravura or Libertinus Serif by name. Registering the fonts with the process has no effect.CeolKitFonts.register()and its outdated comment fromScoreEditApp.init(), and remove theCeolKitSVGRendererimport there, which nothing else used.ScorePreviewView#Preview.libertinusSerifIsAvailableAfterRegistration, which only existed because the app registered the fonts at startup. Rename the remaining suiteFontRegistrationTests→PreviewFontIndependenceTests. Its two tests (previewOutputCarriesNoFontDependency,renderedPageRasterizesToDrawnGeometry) are unchanged.This branch also includes two earlier commits from local
mainthat hadn't been pushed yet:Test plan
tuist generateandxcodebuild -workspace ScoreEdit.xcworkspace -scheme ScoreEdit test: 88 tests in 10 suites passed. That's one fewer test than before (the removed registration test), with the same number of suites.🤖 Generated with Claude Code