-
Notifications
You must be signed in to change notification settings - Fork 103
Add separate rendering starting and complete events #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+193
−91
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ce03b97
Add separate rendering starting and complete events
sbooth dc60cab
Update comments
sbooth 6abcefb
Update comment
sbooth 1f92cd9
Merge branch 'main' into lifecycle-events
sbooth 9e04c38
Merge branch 'main' into lifecycle-events
sbooth ed1f79e
Rename variables
sbooth 06d7e67
Merge branch 'main' into lifecycle-events
sbooth 72021ca
Remove event time from frames rendered event
sbooth 93261e1
Don't break out of frames accounting loop if event enqueue fails
sbooth 25cad9b
Update size of event queue slot
sbooth 6ccf32a
Handle no chunk frames consumed in `enqueueFramesRenderedEvents`
sbooth d21867f
Additional assertions
sbooth b1fb179
Merge branch 'main' into lifecycle-events
sbooth 0c75d7c
Merge branch 'main' into lifecycle-events
sbooth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.