Repository navigation
Conversation
challenge-state-channels, challenge-multisig, challenge-svg-nft are gone from scaffold-eth/se-2-challenges (404), so `-e <name>` failed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're updated deps in se-2, here is the PR updating old foundry deps. Also, during the testing and sre challenges checks AI found some other smaller bugs and I decided to fix them all here in this PR.
forge fmt --checkdoesn't seem so easy test so I think it's better to fix it later in separate PRFoundry counterpart of the hardhat deps refresh from scaffold-eth-2#1326, plus fixes for what surfaced while testing. No Solidity changes.
Deps (
packages/foundry/package.json)Versions are picked to pass the template's
npmMinimalAgeGate: 7d.Code
checkAccountBalance.js: viem public client (getBalance,getTransactionCount,formatEther) instead of ethers v5. ethers was used only here; viem is already the stack's client lib, has no background network detection (ethers v6 kept the process alive retrying unreachable RPCs), andretryCount: 0keeps dead endpoints failing in ~15 ms. Error line showsHTTP <status>or the first line of the RPC error.generateTsAbis.js:prettier.formatis async in v3.Prettier config:
.prettier.jsonwas never read by prettier (wrong filename), somake lint/make formatran with defaults. Renamed to.prettierrc.jsonand formattedscripts-jswith it (printWidth 120, arrowParens avoid, trailingComma all): formatting only, verified token-equivalent apart from the two files above.foundry.tomlrpc_endpoints: mainnet moved off the deadeth-mainnet.alchemyapi.io(same fix as scaffold-eth-2#1326 for hardhat),polygonMumbai→polygonAmoy(also in[etherscan]),polygonZkEvmTestnet→polygonZkEvmCardona(public RPC, the demo Alchemy key has Cardona disabled),pgn/pgnTestnetremoved (network shut down).scrollSepoliacurrently answers 526 onsepolia-rpc.scroll.io; hardhat uses the same URL, left as is.Checked on a generated foundry instance:
yarn install,prettier --check scripts-js(the JS half ofmake lint) green,forge configresolves the etherscan keys,yarn deployon anvil (dotenv + toml 5 + async prettier produce a validdeployedContracts.ts), balance/nonce loop over everyrpc_endpointsentry via viem: all live networks answer, dead ones fail fast, process exits.Extensions list (
src/extensions/challenges.ts): droppedchallenge-state-channels,challenge-multisig,challenge-svg-nft. Their branches no longer exist in scaffold-eth/se-2-challenges (404), so-e <name>failed. Found while checking that no challenge foundry part depends onethers(none does; oracles / lending / stablecoins already ship viem).Not touched:
forge fmt --checkstill fails on the 2-space-indented example contracts vstab_width = 4(separate decision).🤖 Generated with Claude Code