Repository navigation
feat(website): a website env is one server image, checked at its health path (FD-4683) - #390
Merged
Merged
Conversation
williamloo-scale
marked this pull request as ready for review
October 29, 2026 21:03
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
williamloo-scale
changed the title
williamloo-scale
changed the title
williamloo-scale
force-pushed
the
wloo/web-app-contract
branch
from
October 30, 2026 05:23
e4c1cc6 to
f4e254f
Compare
williamloo-scale
changed the title
…th path (FD-4683) A site's server image serves its pages and API, so a website env no longer needs a separate frontend image: one still deploys, put warns that it's deprecated, and a bundle may leave it out. The env declares the path that answers once it's usable, which holds only plain path characters. The server image is stored as server_docker_image_artifact beside backend_docker_image_artifact, which an older document holds and is read as it, and backend_image in an env.toml names it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
williamloo-scale
force-pushed
the
wloo/web-app-contract
branch
from
October 30, 2026 05:46
f4e254f to
2861aa3
Compare
williamloo-scale
changed the title
# Conflicts: # AGENTS.md # src/agent_env/entity/refs.py
earakely-scale
approved these changes
Nov 2, 2026
… plane off the site's route (FD-4683) (#391) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…s path (FD-4683) website/v1 reserves /.well-known/agent-env.json for the env card, and conformance's required reserved-paths check already fails a server that answers it with a page. A deploy waiting for such a site (a single-page app answering every path with index.html) failed to read the card on each poll and timed out. It now refuses the site at once with WebsiteContractError, naming the path and what answered it. Any answer but 200 there is still no card, which falls back to the health path. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
AGENTS.md: main's rows, with this branch's website env, the gateway's site route and the website state verifier added back in. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ke, and ignore node_modules (FD-4683) They were installed to build the page for a browser check and swept into 7756096 with the rest of its change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the website env item of M5 in CUA Env: Computer Envs and Computer App Envs (Websites in the computer, agreed Oct 26), extending the existing
WebsiteEnv. A website env is one server image that serves the site's pages and API, so it no longer needs a separate frontend image. An env with one still deploys, put warns that it's deprecated, and a bundle may leave it out. The env declares thehealthpath that answers once it's usable. Existing envs keep loading: the server image is written asserver_docker_image_artifactbesidebackend_docker_image_artifact, which an older document holds and is read as the server image, andbackend_imagein an env.toml names it. Declared domains wait for the M5 site proxy that routes by them.Validation: unit suite passes, with tests for one-image envs, health-path refusals, reading an older document, the frontend deprecation warning, and an optional image key in a bundle.
🤖 Generated with Claude Code
The PR appears safe to merge; the numbered previous finding is fixed and no new blocking issues remain.Summary
Makes a website env one server image, keeps older two-image envs readable, and checks whether each site is ready.
Reviews (13) · Last reviewed commit: "chore(website): drop the Notes page's no..." · Reviewed by Greptile