Repository navigation
Conversation
Hello cuervino,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
ℹ️ No review performedNo test review was performed: no code under test could be determined: the pull request changes no code and no tests. |
| </pre> | ||
|
|
||
| Fira Code includes programming ligatures: sequences like `=>`, `!==`, `->`, `>=`, and `<=` render as composite glyphs. These are enabled by default. | ||
| Fira Code includes programming ligatures, where sequences like `=>`, `!==`, `->`, `>=` and `<=` render as a single glyph. Ligatures are disabled by default, so every character stays visible as typed. |
There was a problem hiding this comment.
Nothing in the library disables ligatures: the Fira Code @font-face in src/lib/index.css sets no font-feature-settings, and browsers turn liga/calt on by default. Only the sample <pre> above sets fontVariantLigatures: "none". Either add font-variant-ligatures: none where Fira Code is applied, or state it as a rule for callers.
| Fira Code includes programming ligatures, where sequences like `=>`, `!==`, `->`, `>=` and `<=` render as a single glyph. Ligatures are disabled by default, so every character stays visible as typed. | |
| Fira Code includes programming ligatures, where sequences like `=>`, `!==`, `->`, `>=` and `<=` render as a single glyph. Turn them off with `font-variant-ligatures: none` so every character stays visible as typed. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
The Typography guideline asked for Fira Code on technical identifiers, endpoints and version strings. Product UIs do not do this: an ID, an ARN or an endpoint in a table, a key-value list or a form is displayed in Lato. An agent following the guideline produced key-value lists in Fira Code.
The guideline now keeps Fira Code for code blocks, the Editor, snippets to copy, and technical values inside running text (a chat answer, a documentation page). A technical value in the interface itself uses Lato.