Repository navigation
ci(agent): bump golangci-lint to v2.14.0, let Renovate track the tools (MK8S-470) - #35
Open
ezekiel-alexrod wants to merge 2 commits into
Open
ezekiel-alexrod wants to merge 2 commits into
ezekiel-alexrod wants to merge 2 commits into
Conversation
v2.12.2 can't read Go 1.27 export data, so the lint job fails on the Go 1.27 bump. Renovate didn't track the linter here: the annotations let the platform-renovate custom managers pick up the Makefile and .custom-gcl.yml together. v2.14.0 raises one modernize finding on main, fixed with errors.AsType. Refs: MK8S-470
ezekiel-alexrod
requested review from
anthony-treuillier-scality and
eg-ayoub
October 16, 2026 16:32
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
ezekiel-alexrod
marked this pull request as draft
October 16, 2026 16:46
Renovate didn't see the kustomize and controller-gen versions in the Makefile. The annotations let the platform-renovate Makefile custom manager bump them. The test job regenerated the CRDs, RBAC and deepcopy code but never compared the result with what is committed, so a controller-gen bump or an edited API type could merge with stale files. The job now fails when make test leaves a diff. YEAR is fixed in the Makefile, or every generated header would change each January. Nothing ran kustomize in CI, so the job now builds config/default too. Refs: MK8S-470
1 task done
ezekiel-alexrod
changed the title
ezekiel-alexrod
marked this pull request as ready for review
October 19, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component
agent, ci, docs
Problem
Renovate's Go 1.27 bump (#14) fails
lint: golangci-lint v2.12.2 can't read Go 1.27 export data (export data version 5 is greater than maximum supported version 4). Renovate never proposed a newer linter, and it doesn't see kustomize or controller-gen either: nothing tells it where those versions live.Fix
Start with the second commit, it's the one with a choice in it. The first one is mechanical.
agent/Makefileandagent/.custom-gcl.yml. v2.15.0 came out on Oct 16, Renovate will bring it after the usual delay.# renovate:annotations on golangci-lint (both files), kustomize and controller-gen. Theplatform-renovatecustom managers then bump them, golangci-lint in one PR for both files.modernizefinding onmain:errors.As->errors.AsTypeininternal/puller/puller_test.go.testjob now fails whenmake testleaves a diff. It regenerated the CRDs but never compared them, so a controller-gen bump would have merged with stale CRDs. Such a bump now needsmake manifestscommitted, like any API change.CONTRIBUTING.mdsaid the opposite, it's updated.The Go 1.27 bump itself comes in a follow-up PR once this one is merged.
Test
make -C agent lintonmain+ this PR, Go 1.26.9, aftercache cleanmake -C agent testonmain+ this PRgit status --porcelainstays emptyCONTROLLER_TOOLS_VERSION=v0.23.0main+ #14, Go 1.27.2embedlitones of the follow-upplatform-renovateMakefile and YAML regexes on both filesv2.14.0, kustomizev5.8.1, controller-toolsv0.21.0actionlint .github/workflows/agent-ci.yamlOut of scope
logcheckplugin stays onlatestin.custom-gcl.yml.make lintrebuilds golangci-lint on every run: the rule comes as is from the kubebuilder scaffold.Relates-to: MK8S-470