Skip to content

fix(cli): render nested compositions from the CLI - #42

Merged
scbrown merged 2 commits into
mainfrom
grant/nested-composition-render
Nov 15, 2026
Merged

scbrown merged 2 commits into
mainfrom
grant/nested-composition-render

Conversation

@scbrown

@scbrown scbrown commented Nov 12, 2026

Copy link
Copy Markdown
Owner

The CLI resolves every composition reference as a sprite, so a documented nested composition saves an empty image with missing-sprite/grid warnings. Resolve composition references recursively through the existing validated CLI rendering path, sharing the existing render context for completed-image caching and cycle detection. Sprites/variants retain name precedence. This applies to filtered/default compositions, nested bases and animation frames.

Closes #34.

Validation: both original nested-render and cycle regressions fail on the base, then pass. Five CLI controls compare full RGBA output and cover cycles, nested base/animation, size validation and name precedence. Full cargo test: 2,652 pass, 37 ignored, zero failures across 25 suites. Clippy all targets with lsp,wasm and warnings denied passes. HOME guard: 162 paths and 5 UID resources untouched. An initial library-renderer unification attempt exposed a different nested-library layout contract; it was removed, retaining the existing validated composer and library API behavior.

Demo: the same 8x8 scene goes from 0 visible pixels and false missing/grid warnings to all four dots (16 visible pixels), without those warnings. Caption/reproduction, terminal recording, timing. Source-checkout demonstration; no installed executable changed.

Bead: aegis-sg3

Overlap preflight: 4ff7eb3c6f574b2ee3899394130585bf1c2df7ed82f340b219ef64f6a7242b79

@scbrown scbrown changed the title Render nested compositions from the CLI fix(cli): render nested compositions from the CLI Nov 14, 2026
@scbrown
scbrown merged commit e960980 into main Nov 15, 2026
16 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nested compositions are documented but do not render

1 participant