Repository navigation
fix(cli): render nested compositions from the CLI - #42
Merged
Merged
Conversation
This was referenced Nov 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI resolves every composition reference as a sprite, so a documented nested composition saves an empty image with missing-sprite/grid warnings. Resolve composition references recursively through the existing validated CLI rendering path, sharing the existing render context for completed-image caching and cycle detection. Sprites/variants retain name precedence. This applies to filtered/default compositions, nested bases and animation frames.
Closes #34.
Validation: both original nested-render and cycle regressions fail on the base, then pass. Five CLI controls compare full RGBA output and cover cycles, nested base/animation, size validation and name precedence. Full cargo test: 2,652 pass, 37 ignored, zero failures across 25 suites. Clippy all targets with lsp,wasm and warnings denied passes. HOME guard: 162 paths and 5 UID resources untouched. An initial library-renderer unification attempt exposed a different nested-library layout contract; it was removed, retaining the existing validated composer and library API behavior.
Demo: the same 8x8 scene goes from 0 visible pixels and false missing/grid warnings to all four dots (16 visible pixels), without those warnings. Caption/reproduction, terminal recording, timing. Source-checkout demonstration; no installed executable changed.
Bead: aegis-sg3
Overlap preflight: 4ff7eb3c6f574b2ee3899394130585bf1c2df7ed82f340b219ef64f6a7242b79