Skip to content

Update async-executor to 1.14.1 and correct SECURITY.md - #26

Merged
schreck61 merged 2 commits into
mainfrom
update-async-executor
Nov 16, 2026
Merged

schreck61 merged 2 commits into
mainfrom
update-async-executor

Conversation

@schreck61

Copy link
Copy Markdown
Owner

What and why

Two small corrections: a follow-up recorded in #19, and one that a check of the project's documents against the code turned up.

  • A yanked dependency. Cargo.lock has pinned async-executor 1.14.0 since the first release, and that version was yanked on November 2. It can use memory after it is freed when a waker fires while an executor is being dropped (issue 163 of the async-executor repository), and 1.14.1 undoes the change that caused it. Only the Linux build uses the crate, through AccessKit's screen-reader bridge and zbus. cargo deny has warned about it on every CI run since then without failing (yanked = "warn"), and Dependabot's version updates cover only the dependencies named in Cargo.toml, so no tool proposed the update. The first commit moves the lock file to 1.14.1, the only crate that changes, and regenerates THIRD_PARTY_LICENSES.md for it. It doesn't change how such a crate gets noticed: yanked stays at "warn", and Dependabot's version updates still cover only the dependencies named in Cargo.toml.
  • One sentence in SECURITY.md. It said a weights file that fails its check "is rejected rather than run". That holds for a Deep RL file. A Hybrid file whose network fails the check still loads: the network is left out and the controller runs the base tuning saved in the file. The page now says what holds for both, that a network that fails the check is never run, as docs/assurance-case.md and section 8.7 of docs/architecture.md already do. Such a Hybrid file passes no check and can still manage traffic badly, so SECURITY.md and the remaining risks in docs/assurance-case.md now say that of a file that loads, not of one that passes.

No source file changes, so traffic and results are unchanged.

Checklist

  • cargo test --locked --release passes (zero vehicle overlaps)
  • The code is formatted with cargo fmt --all
  • cargo clippy --locked --release --all-targets -- -D warnings is clean (and for wasm32-unknown-unknown if the app changed)
  • New functionality has tests, and a bug fix has a test that fails without it (see CONTRIBUTING.md) (no functionality changes; the behavior SECURITY.md now describes is pinned by tests/weights_files.rs)
  • Runs stay deterministic for a given seed
  • README, docs/insights.md and in-app text are updated where results or behavior changed (neither changed)
  • New dependencies, if any, are explained and THIRD_PARTY_LICENSES.md is regenerated (no new dependency; regenerated for the new version)
  • I've noted anything I couldn't test (for example a platform I don't have)
  • Every commit is signed off (git commit -s) under the Developer Certificate of Origin

Not tested before opening: Linux, which is the only platform that compiles async-executor. The tests, Clippy, the crate package, cargo deny --locked check (now without the yanked-crate warning) and packaging/licenses.sh --check ran on macOS with Rust 1.100, where the crate is fetched and its checksum verified but not built. CI's Linux jobs are the first to compile 1.14.1, and nothing in CI runs it: the tests drive the app without a window, and the screen-reader bridge that uses the crate starts only when the app opens one. The Linux app itself has not been run with 1.14.1.

By submitting this pull request, I agree that my contribution is dual licensed under MIT OR Apache-2.0, as described in CONTRIBUTING.md.

The lock file has pinned async-executor 1.14.0 since the first release,
and that version was yanked on November 2. It can use memory after it
is freed when a waker fires while an executor is being dropped (issue
163 of the async-executor repository); 1.14.1 undoes the change that
caused it.

Only the Linux build uses the crate, through AccessKit's screen-reader
bridge and zbus. cargo deny has warned about the yanked version on every
CI run since then without failing, and Dependabot's version updates
cover only the dependencies named in Cargo.toml, so no tool proposed the
update.

No other crate in the lock file changes. THIRD_PARTY_LICENSES.md is
regenerated for the new version.

Signed-off-by: Jim Schreckengast <schreck@gmail.com>
SECURITY.md said a weights file that fails its check is rejected rather
than run. That holds for a Deep RL file. A Hybrid file whose network
fails the check still loads: the network is left out and the controller
runs the base tuning saved in the file.

What holds for both is that a network that fails the check is never
run. The page says that now, as docs/assurance-case.md and section 8.7
of docs/architecture.md already do.

Such a Hybrid file passes no check and can still manage traffic badly,
so SECURITY.md and the remaining risks in docs/assurance-case.md now
say that of a file that loads, not of one that passes.

Signed-off-by: Jim Schreckengast <schreck@gmail.com>
@schreck61
schreck61 enabled auto-merge (rebase) November 16, 2026 02:28
@schreck61
schreck61 merged commit 5e10f06 into main Nov 16, 2026
13 checks passed
@schreck61
schreck61 deleted the update-async-executor branch November 16, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant