Repository navigation
Update async-executor to 1.14.1 and correct SECURITY.md - #26
Merged
Merged
Conversation
The lock file has pinned async-executor 1.14.0 since the first release, and that version was yanked on November 2. It can use memory after it is freed when a waker fires while an executor is being dropped (issue 163 of the async-executor repository); 1.14.1 undoes the change that caused it. Only the Linux build uses the crate, through AccessKit's screen-reader bridge and zbus. cargo deny has warned about the yanked version on every CI run since then without failing, and Dependabot's version updates cover only the dependencies named in Cargo.toml, so no tool proposed the update. No other crate in the lock file changes. THIRD_PARTY_LICENSES.md is regenerated for the new version. Signed-off-by: Jim Schreckengast <schreck@gmail.com>
SECURITY.md said a weights file that fails its check is rejected rather than run. That holds for a Deep RL file. A Hybrid file whose network fails the check still loads: the network is left out and the controller runs the base tuning saved in the file. What holds for both is that a network that fails the check is never run. The page says that now, as docs/assurance-case.md and section 8.7 of docs/architecture.md already do. Such a Hybrid file passes no check and can still manage traffic badly, so SECURITY.md and the remaining risks in docs/assurance-case.md now say that of a file that loads, not of one that passes. Signed-off-by: Jim Schreckengast <schreck@gmail.com>
schreck61
enabled auto-merge (rebase)
November 16, 2026 02:28
This was referenced Nov 16, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Two small corrections: a follow-up recorded in #19, and one that a check of the project's documents against the code turned up.
Cargo.lockhas pinnedasync-executor1.14.0 since the first release, and that version was yanked on November 2. It can use memory after it is freed when a waker fires while an executor is being dropped (issue 163 of the async-executor repository), and 1.14.1 undoes the change that caused it. Only the Linux build uses the crate, through AccessKit's screen-reader bridge and zbus.cargo denyhas warned about it on every CI run since then without failing (yanked = "warn"), and Dependabot's version updates cover only the dependencies named inCargo.toml, so no tool proposed the update. The first commit moves the lock file to 1.14.1, the only crate that changes, and regeneratesTHIRD_PARTY_LICENSES.mdfor it. It doesn't change how such a crate gets noticed:yankedstays at"warn", and Dependabot's version updates still cover only the dependencies named inCargo.toml.SECURITY.md. It said a weights file that fails its check "is rejected rather than run". That holds for a Deep RL file. A Hybrid file whose network fails the check still loads: the network is left out and the controller runs the base tuning saved in the file. The page now says what holds for both, that a network that fails the check is never run, asdocs/assurance-case.mdand section 8.7 ofdocs/architecture.mdalready do. Such a Hybrid file passes no check and can still manage traffic badly, soSECURITY.mdand the remaining risks indocs/assurance-case.mdnow say that of a file that loads, not of one that passes.No source file changes, so traffic and results are unchanged.
Checklist
cargo test --locked --releasepasses (zero vehicle overlaps)cargo fmt --allcargo clippy --locked --release --all-targets -- -D warningsis clean (and forwasm32-unknown-unknownif the app changed)SECURITY.mdnow describes is pinned bytests/weights_files.rs)THIRD_PARTY_LICENSES.mdis regenerated (no new dependency; regenerated for the new version)git commit -s) under the Developer Certificate of OriginNot tested before opening: Linux, which is the only platform that compiles
async-executor. The tests, Clippy, the crate package,cargo deny --locked check(now without the yanked-crate warning) andpackaging/licenses.sh --checkran on macOS with Rust 1.100, where the crate is fetched and its checksum verified but not built. CI's Linux jobs are the first to compile 1.14.1, and nothing in CI runs it: the tests drive the app without a window, and the screen-reader bridge that uses the crate starts only when the app opens one. The Linux app itself has not been run with 1.14.1.By submitting this pull request, I agree that my contribution is dual licensed under MIT OR Apache-2.0, as described in CONTRIBUTING.md.