Repository navigation
Remove unnececessary Python versions in integration tests. Remove support for Python 3.8 - #1282
Open
Joao-Dionisio wants to merge 5 commits into
Open
Joao-Dionisio wants to merge 5 commits into
Joao-Dionisio wants to merge 5 commits into
Conversation
Member
|
Smart! yes we should do that. How about two variables holding the "latest" and "oldest" so that the intention is documented in the github workflows? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1278 resulted in a pipeline being merged with one of the jobs skipped, because GitHub couldn't allocate a Mac runner for all of them. We're on a free plan, so we're limited to 5 Mac jobs, I believe.
I think we only need to run the latest version (3.15 atm), to catch potential errors, and 3.9 as well just to be safe. Never has an integration test of an intermediate version caught a bug that wasn't caught by the lowest or the highest versions.
The version of cibuildwheel we're currently using no longer supports Python 3.8, so I suggest dropping it as well.