Repository navigation
[essreduce] DetectorExplorer for viewing and masking detector banks #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nvaytet
wants to merge
64
commits into
main
Choose a base branch
from
masking-diagnostics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
05aafa3
begin working on generic detector bank viewer and masker
nvaytet ed36113
width initial
nvaytet e84ccd3
fix arg in full_like
nvaytet c885553
add functionality for switching displayed dims
nvaytet 592b3a3
better comment
nvaytet 479dee0
avoid error if size is not in da
nvaytet 002325d
start adding masking functionality
nvaytet 47e0e05
make sliders for every bank and hide them, only displaying master sli…
nvaytet 1d7aa4f
also link checkboxes
nvaytet 87d55e6
sliders inside tabs
nvaytet 84a34a3
get masking working
nvaytet f5dd00f
better masking performance
nvaytet 3412e93
better color control
nvaytet 04312e7
fix continuous masking and cleanup
nvaytet e7b186b
add masks clearing button
nvaytet 4a7a1ff
add save masks
nvaytet 31e480a
add continuous control
nvaytet 0a7bccc
fix saving masks
nvaytet 3e38f26
adjust spacing
nvaytet 6ff16b1
fix cmap range when switching tabs
nvaytet 26ea228
refactor to split responsibilities better
nvaytet 4d550cd
move color control into class
nvaytet 691732d
go back to having logic on the main object
nvaytet d67f76f
disabled save button, and link slider values when switching tabs
nvaytet c488eb9
cleanup
nvaytet 36738d0
fix bug in mask buttons sync
nvaytet 63a49fc
Merge branch 'main' into masking-diagnostics
nvaytet 99b3da8
move into disgnostics folder and update loki viewer
nvaytet e538a79
remove unused file
nvaytet 71c2207
start adding tests
nvaytet 9cc7bd2
add tests written by clause
nvaytet 4756a6d
needs recent plopp
nvaytet e405af9
update pixi lock
nvaytet 06d4abe
fix esssans tests
nvaytet ed232d4
fix package test
nvaytet 0d6d1c2
add ipympl in test deps for essreduce
nvaytet d5b8291
update lock file
nvaytet b5ae4da
fix deprecation warning
nvaytet 927f9d5
better icons
nvaytet 3e041ae
add prev/next buttons to each slider
nvaytet 1003638
remove obsolete test
nvaytet 1455f22
only add coords if they are missing
nvaytet f380010
disable slider if one bank does not have slider dim
nvaytet d8b808d
add test for uneven banks
nvaytet 0be4c60
use dicts of masks for each dimension combination
nvaytet 33eda28
fix delete logic, add transpose back in and add a couple of tests
nvaytet 3b1ae66
cleanup
nvaytet 5aa2365
fix some tests
nvaytet cdd5f58
fix more tests
nvaytet d97d826
remove not very useful test
nvaytet 738ec74
remove unused imports
nvaytet 324409d
remove continuous masking, fix coord indexing and also bin edges
nvaytet e92b6b3
cleanup
nvaytet 293cac4
fix bad dim slicing when bank is missing a dim
nvaytet 7ae9e04
do not update color on every keystroke
nvaytet 64503e5
require recent plopp for tests also
nvaytet 050464a
remove self._visible_dims and self._lock
nvaytet e1560cd
function signature and docstring, and prevent against bad show_dims
nvaytet ceba850
update pixi lock
nvaytet 72d5ab8
start changing mechanism to accept dict of masks which defines what t…
nvaytet 4fbabc9
start refactor to simplify code
nvaytet 9d562a3
cleanup
nvaytet 956162d
Merge branch 'main' into masking-diagnostics
nvaytet 78f6bbb
use new pixel masks format
nvaytet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DetectorExplorerfails with plopp 26.7 (AxesImage.set() got an unexpected keyword argument 'hide_log_buttons'), but only thedocsextra has the>=26.10.0bound. Couldtesthave it too?