Repository navigation
Conversation
jl-wynen
approved these changes
Nov 13, 2026
jl-wynen
left a comment
Member
There was a problem hiding this comment.
Seems like we need to not approve code that we didn't read thoroughly
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The order in which masks are saved in the nexus files is backwards: https://github.com/scipp/ess/blob/main/packages/essreduce/src/ess/reduce/masking.py#L172
It’s getting
namefrom the top level, which should be'loki_detector_0', but then creates theNXdetectorusingbankwhich is actually'bad_tubes'in my case.Masks should have this structure to start with:

masks = {'loki_detector_0': {'bad_tubes': sc.array()}}This is how the ADR reads:
The result in the nexus file is that the

NXdetectoris calledbad_tubes.In this PR we invert the logic and save the masks as intended.