Skip to content

test(guards): memory-usage sqlite cases quote the sqlite3 path and drop its CR (CC-696, refs #783) #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
screenleon merged 1 commit into from
Nov 5, 2026
Merged

test(guards): memory-usage sqlite cases quote the sqlite3 path and drop its CR (CC-696, refs #783) #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion BACKLOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ CC-001/CC-002 were consumed by PR #24 fix bundle inline, with no standalone entr
| CC-692 | 🔵 active | **[測試套件太慢：`test-pr-gate.sh` 約 330 個案例每個都跑完整 gate，本機 WSL 每分片 8 到 14 分鐘；判斷類案例應降到函式層，端到端只留接線]** 第 1 步（試點）：`gate_reviewer_protocol_verify` 的 9 個純診斷案例改在新 suite `test-gate-reviewer-protocol.sh` 直接呼叫函式（含正向對照與突變驗證），`test-pr-gate.sh` 保留 2 個接線案例；計畫見下方 CC-692 一節。 | ops/test | 2026-11-02 | feedback:2026-11-02 pr:#764 | P2 | hygiene |
| CC-693 | 🔵 active | **[`gate run` 的 context 階段在新 worktree 每次耗滿 90 秒上限且不保留進度（issue #780）]** 根因：`pmctl_context_workflow_refresh_bounded` 只用 `timeout 90` 從外面殺掉，`workflow-refresh` 沒傳預算給索引，索引在最後才 COMMIT，被殺就全丟。修法：`workflow-refresh` 新增 `--budget-ms`，wrapper 傳上限的三分之二，索引自己停下並保留進度，下一次接續（重用 #760 的機制）。 | ops/gate | 2026-11-05 | feedback:2026-11-05 pr:#784 | P2 | hygiene |
| CC-694 | 🔵 active | **[`PM_DISPATCH_STATE_ROOT` 用盘符写法时 `gate run` 先报告 detached 启动成功，监督进程不到 1 秒后才以 exit 2 失败（issue #779）]** `gate run` 在父程序、context 刷新與 operation record 之前檢查狀態根的寫法，拒絕時 exit 2、訊息指名變數（`PM_DISPATCH_STATE_ROOT` 或 `XDG_DATA_HOME`），不印 gate id；`docs/platform-support.md` 補一條。 | ops/gate | 2026-11-05 | feedback:2026-11-05 pr:#785 | P2 | hygiene |
| CC-695 | 🔵 active | **[Windows 的 state root ACL 守衛：拒絕訊息沒有說是哪個主體（issue #778），測試的 `%TEMP%` 繼承 `CodexSandboxUsers` 讓 7 個 telemetry 案例失敗（issue #782）]** 守衛本身是對的，不放寬：訊息指名第一個違規主體與是否繼承，附上 `PM_DISPATCH_STATE_ROOT` 補救與不要隨手改父目錄 ACL 的提醒，`docs/platform-support.md` 補一條；`test-pmctl-context.sh` 用 `th_secure_state_root` 給 tmp_root 一個 owner-only ACL。 | ops/portability | 2026-11-05 | feedback:2026-11-05 | P2 | hygiene |
| CC-695 | 🔵 active | **[Windows 的 state root ACL 守衛：拒絕訊息沒有說是哪個主體（issue #778），測試的 `%TEMP%` 繼承 `CodexSandboxUsers` 讓 7 個 telemetry 案例失敗（issue #782）]** 守衛本身是對的，不放寬：訊息指名第一個違規主體與是否繼承，附上 `PM_DISPATCH_STATE_ROOT` 補救與不要隨手改父目錄 ACL 的提醒，`docs/platform-support.md` 補一條；`test-pmctl-context.sh` 用 `th_secure_state_root` 給 tmp_root 一個 owner-only ACL。 | ops/portability | 2026-11-05 | feedback:2026-11-05 pr:#786 | P2 | hygiene |
| CC-696 | 🔵 active | **[原生 Windows 上 `memory-usage/sqlite-*` 三個案例穩定失敗：測試把含空白的 sqlite3 路徑不加引號、又不處理原生 sqlite3 的 CRLF（issue #783）]** 這三個案例的 `$real_sqlite "$db" ...` 沒有加引號，使用者目錄含空白（`/c/Users/Lien Chen/...`）時指令被拆開，查詢結果為空而讀成 `missing`；且原生 `sqlite3` 輸出 CRLF，bash 的命令替換只去掉結尾的換行字元，留下 CR。測試改為加引號並去掉 CR，產品程式沒有問題（資料庫內容正確）。並行兩個案例在 main 上現在通過，沒有重現。 | ops/test | 2026-11-05 | feedback:2026-11-05 | P2 | hygiene |

---

Expand Down Expand Up @@ -2606,3 +2607,19 @@ symlink 或改名的 adapter 仍被拒絕。
**未做**：`test-pmctl-context.sh` 其餘既有失敗（兩個 `no-arg ... external git repo` 案例以 exit 99 被隔離守衛拒絕、`marker round-trip`）與 ACL 無關，未動；整個套件超過 900 秒上限沒有完整跑；issue #778 建議 3（把已知 Codex 沙箱組列為可配置的允許名單）需要安全上的決定，沒做；守衛仍只指名第一個違規主體。

**See**: issue #778、#782、[[CC-694]]；docs/platform-support.md 的 Windows 一節。

---

## CC-696 — `memory-usage/sqlite-*` 三個案例在原生 Windows 失敗 🔵 active

**Problem**：issue #783。`bash tests/shell/test-guards.sh --filter memory-usage` 在原生 Windows 上 5 個案例失敗；不是迴歸（`61b75ae` 也一樣）。

**根因（三個 sqlite 案例）**：資料庫其實寫對了（手動重現：`card_usage` 有 `a.md|1|100`，`metadata` 有 `total_events`）。是測試讀它的方式錯了：(1) `$($real_sqlite "$db" ...)` 沒有加引號，`real_sqlite` 是 `/c/Users/Lien Chen/AppData/.../sqlite3`，路徑含空白就被拆成 `/c/Users/Lien` 與其餘參數，指令找不到、輸出為空，報告成 `count=missing`；(2) 原生 `sqlite3` 輸出 `\r\n`，命令替換只去掉結尾的 `\n`，就算指令成功也會多一個 `\r`，與預期字串不相等。

**修法**：三個案例的 `$real_sqlite` 加引號，輸出接 `tr -d '\r'`。產品程式（`memory_usage_commit`）沒有改。

**驗證（原生 Windows）**：`--filter memory-usage`：main 上 12 通過 3 失敗，改後 15 通過 0 失敗。

**未重現**：issue 列的兩個並行案例（`concurrent-no-lost-updates` 8 個 writer 逾時 20 秒、`contention-matrix-flock-and-mkdir-fallback`）在這台機器上 main 就通過（分別約 12 秒與 34 到 46 秒，連跑三次都過），所以它們是負載相關的逾時，不是穩定失敗；#738 要求的 50 個並行 writer 的 exactly-once 驗收在原生 Windows 上仍未驗證。

**See**: issue #783、#738。
12 changes: 7 additions & 5 deletions tests/shell/test-guards.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2932,8 +2932,10 @@ memory_usage_sqlite_busy_retries_exactly_once() {
bail_count="$(memory_usage_fake_sqlite_bail_count "$state")"
sql_same=no
cmp -s "$state/sql.1" "$state/sql.2" && cmp -s "$state/sql.2" "$state/sql.3" && sql_same=yes
count="$($real_sqlite "$db" "SELECT access_count FROM card_usage WHERE card_relpath='a.md';" 2>/dev/null || true)"
total="$($real_sqlite "$db" "SELECT value FROM metadata WHERE key='total_events';" 2>/dev/null || true)"
# Quoted, and the CR a native Windows sqlite3 prints is dropped: the path of the binary can hold a space
# (a profile directory) and the bash substitution keeps a trailing CR (issue #783).
count="$("$real_sqlite" "$db" "SELECT access_count FROM card_usage WHERE card_relpath='a.md';" 2>/dev/null | tr -d '\r' || true)"
total="$("$real_sqlite" "$db" "SELECT value FROM metadata WHERE key='total_events';" 2>/dev/null | tr -d '\r' || true)"
stderr_state=nonempty; [[ ! -s "$d/stderr" ]] && stderr_state=empty
leftovers="$(find "$d/tmp" -maxdepth 1 \( -name 'memory-usage.*.sql' -o -name 'memory-usage.*.err' \) -print | wc -l | tr -d ' ')"
printf 'rc=%s calls=%s pauses=%s bail=%s sql-same=%s count=%s total=%s stderr=%s leftovers=%s\n' \
Expand Down Expand Up @@ -2973,7 +2975,7 @@ memory_usage_sqlite_success_does_not_retry() {
memory_usage_commit "$db" 1000000 100 a.md 2> "$d/stderr" || rc=$?
calls="$(cat "$state/calls" 2>/dev/null || printf 0)"
pauses=0; [[ -f "$state/pauses" ]] && pauses="$(wc -l < "$state/pauses" | tr -d ' ')"
count="$($real_sqlite "$db" "SELECT access_count FROM card_usage WHERE card_relpath='a.md';" 2>/dev/null || true)"
count="$("$real_sqlite" "$db" "SELECT access_count FROM card_usage WHERE card_relpath='a.md';" 2>/dev/null | tr -d '\r' || true)"
printf 'rc=%s calls=%s pauses=%s bail=%s count=%s stderr-empty=%s\n' \
"$rc" "$calls" "$pauses" "$(memory_usage_fake_sqlite_bail_count "$state")" \
"${count:-missing}" "$([[ ! -s "$d/stderr" ]] && printf yes || printf no)"
Expand Down Expand Up @@ -3088,8 +3090,8 @@ memory_usage_sqlite_retry_keeps_import_and_decay_exactly_once() {
rc=0
PATH="$d/fake/bin:$PATH" TMPDIR="$d/tmp" \
memory_usage_commit "$db" 4 100 a.md 2> "$d/stderr" || rc=$?
row="$($real_sqlite -separator ' ' "$db" \
"SELECT c.access_count,m.value,i.value FROM card_usage c JOIN metadata m ON m.key='total_events' JOIN metadata i ON i.key='legacy_imported' WHERE c.card_relpath='a.md';" 2>/dev/null || true)"
row="$("$real_sqlite" -separator ' ' "$db" \
"SELECT c.access_count,m.value,i.value FROM card_usage c JOIN metadata m ON m.key='total_events' JOIN metadata i ON i.key='legacy_imported' WHERE c.card_relpath='a.md';" 2>/dev/null | tr -d '\r' || true)"
printf 'rc=%s calls=%s pauses=%s row=%s stderr-empty=%s\n' \
"$rc" "$(cat "$state/calls" 2>/dev/null || printf 0)" \
"$(wc -l < "$state/pauses" 2>/dev/null | tr -d ' ')" "${row:-missing}" \
Expand Down
Loading