Repository navigation
Test/database sqlmock - #124
Merged
Merged
Conversation
Member
|
@ashb155, would you be able to take a first look at this PR? :) |
Collaborator
|
will have a look @andrewtavis ! |
ashb155
approved these changes
Oct 23, 2026
ashb155
left a comment
ashb155
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me @andrewtavis @DeleMike !
andrewtavis
approved these changes
Oct 23, 2026
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
./pre-commitexecutable as well asmake lintand have fixed all reported issuesDescription
Adds tests for the database package using go-sqlmock (BSD-3-Clause), so the tests don't need MariaDB.
Also, this PR also fixes a silent bug in
GetTableSchema,GetTableData,GetAvailableLanguagesandGetLanguageDataTypes. That is, if reading rows failed partway through, they returned partial results without an error. As/api/v1/data/{lang}uses the first two functions, the client could receive an incomplete language pack. They now return an error instead.Related issue