Skip to content

add tests for GetLanguageVersion handler - #127

Merged
andrewtavis merged 2 commits into
scribe-org:mainfrom
ashb155:test/get-language-version-handler
Oct 26, 2026
Merged

andrewtavis merged 2 commits into
scribe-org:mainfrom
ashb155:test/get-language-version-handler

Conversation

@ashb155

@ashb155 ashb155 commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • I have ran the ./pre-commit executable as well as make lint and have fixed all reported issues

Description

This PR adds unit tests for the GET /api/v1/data-version/{lang} endpoint handler (GetLanguageVersion),

Coverage

  • api/handlers/language.go (GetLanguageVersion): 0.0% -> 100.0%
  • api/handlers package statements: 91.9% -> 100.0%

Related issue

@DeleMike DeleMike left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashb155 for this! It looks good to me :)

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: On my end as well this is looking great, @ashb155! So amazing that we're so close to having the tests done 🤩

@andrewtavis
andrewtavis merged commit 66baa37 into scribe-org:main Oct 26, 2026
3 checks passed
@ashb155

ashb155 commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator Author

thanks @andrewtavis @DeleMike !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add handler tests for GET /api/v1/data-version/{lang}

3 participants