Skip to content

Switch /contracts zip name to scribe_data_contracts - #128

Merged
andrewtavis merged 1 commit into
scribe-org:mainfrom
Roniscend:zip_file_name
Oct 24, 2026
Merged

andrewtavis merged 1 commit into
scribe-org:mainfrom
Roniscend:zip_file_name

Conversation

@Roniscend

Copy link
Copy Markdown
Contributor

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • I have ran the ./pre-commit executable as well as make lint and have fixed all reported issues

Description

Updates the contractsArchiveDir constant and all references across handlers, tests, docs, and changelog so the /contracts endpoint serves scribe_data_contracts.zip instead of data_contracts.zip
Fixes : #116

Signed-off-by: Owm <owmdubey163@gmail.com>
@andrewtavis

Copy link
Copy Markdown
Member

So amazing to have you contributing across projects, @Roniscend!

@DeleMike or @ashb155: Does one of you want to review?

@ashb155

ashb155 commented Oct 24, 2026

Copy link
Copy Markdown
Collaborator

i can have a look @andrewtavis !

@ashb155 ashb155 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! @andrewtavis @DeleMike
Thanks for all the work here @Roniscend

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Looks great from my end as well! Thanks for the wonderful first contribution over here, @Roniscend! Looking forward to the next! 🚀

And thanks for the review, @ashb155 😊

@andrewtavis
andrewtavis merged commit 933b630 into scribe-org:main Oct 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch zip file name for /contracts route

3 participants