You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fork seam check reads its allow list from the PR itself #189
From the #185 tests lens (#185 (comment)), minor: a PR that adds a fork key to settings.ts and also lists it in fork-seams.json, or drops settings.ts from the list, goes green. Fix: run the seam check from fork-checks.yml reading fork-seams.json from the base commit (owner-only workflow). Nits: a seam line main already has can be added twice on a PR (fork-follow refuses it later); lines a PR deletes from upstream files are not checked.
Done on main. #277 (d8e78a0) makes CI judge a PR with main's allow list (--config-ref), never the PR's own; the test "The list that judges a pull request is its base's (or --config-ref's), never its own" covers it. Both nits are covered too: a line the file already has cannot be announced again (fork-seam-check.cjs:450), and seam lines a change deletes, moves or edits are counted (fork-seam-check.cjs:120, :489). Closing.
Activity
scuttletoby commentedon Nov 20, 2026
Done on main. #277 (d8e78a0) makes CI judge a PR with main's allow list (
--config-ref), never the PR's own; the test "The list that judges a pull request is its base's (or --config-ref's), never its own" covers it. Both nits are covered too: a line the file already has cannot be announced again (fork-seam-check.cjs:450), and seam lines a change deletes, moves or edits are counted (fork-seam-check.cjs:120, :489). Closing.fork seam check: every upstream file counted, allow list from main (#242